Skip to content

revert: sidebar widget registry refactor#1898

Closed
arbrandes wants to merge 1 commit intoopenedx:masterfrom
arbrandes:revert-sidebar-refactor
Closed

revert: sidebar widget registry refactor#1898
arbrandes wants to merge 1 commit intoopenedx:masterfrom
arbrandes:revert-sidebar-refactor

Conversation

@arbrandes
Copy link
Copy Markdown
Contributor

@arbrandes arbrandes commented Apr 16, 2026

Description

This reverts two recent commits that refactored the sidebar to use a widget registry mechanism (PRs #1885 and #1897):

This feature will have to be refactored with backward compatibility in mind.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 93.47258% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.16%. Comparing base (59113b0) to head (cd38f6b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...urseware/course/new-sidebar/common/SidebarBase.tsx 73.52% 9 Missing ⚠️
...ware/course/new-sidebar/SidebarContextProvider.tsx 90.90% 6 Missing ⚠️
...-notifications/DiscussionsNotificationsTrigger.tsx 91.66% 4 Missing ⚠️
...urseware/course/sidebar/SidebarContextProvider.jsx 86.95% 3 Missing ⚠️
...eware/course/sequence/lock-paywall/LockPaywall.jsx 81.81% 2 Missing ⚠️
...otifications/notifications/NotificationsWidget.tsx 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
- Coverage   91.28%   91.16%   -0.12%     
==========================================
  Files         343      349       +6     
  Lines        5770     5830      +60     
  Branches     1388     1348      -40     
==========================================
+ Hits         5267     5315      +48     
- Misses        484      498      +14     
+ Partials       19       17       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Reverts the following two commits:

- 59113b0 feat: move discussion topic prefetch from trigger to widget
  config lifecycle (openedx#1897)
- 0664dc3 feat: decouple notifications panel using widget registry
  mechanism (openedx#1885)

Co-Authored-By: Claude <noreply@anthropic.com>
@arbrandes arbrandes force-pushed the revert-sidebar-refactor branch from bf282da to cd38f6b Compare April 16, 2026 20:31
@arbrandes
Copy link
Copy Markdown
Contributor Author

We ended up making the thing backward compatible instead.

@arbrandes arbrandes closed this Apr 17, 2026
@arbrandes arbrandes deleted the revert-sidebar-refactor branch April 17, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant