Skip to content

Adding changes for Estimated Time to Complete#1911

Closed
becdavid wants to merge 9 commits into
openedx:teak-design-tokensfrom
CUCWD:dev/nalexaTimeFrontend
Closed

Adding changes for Estimated Time to Complete#1911
becdavid wants to merge 9 commits into
openedx:teak-design-tokensfrom
CUCWD:dev/nalexaTimeFrontend

Conversation

@becdavid
Copy link
Copy Markdown

No description provided.

nalexa3 added 9 commits April 27, 2026 08:14
- Updated normalizeOutlineBlocks to extract effort_time and estimated_time
  (HH:MM:SS) from course blocks.
- Added hydrateMissingOutlineEffort to calculate effort by summing the
  effort times of child units when missing.
- Integrated showEstimatedTime course-level flag into the normalized
  course model.
- Added time-string parsing to convert HH:MM:SS into raw seconds
  for consistent frontend calculations.
- Added estimated-time display logic to section and sequence outline rows,
  using effortTime when available and falling back to unit-level estimated
  time data when needed.
- Passed the showEstimatedTime flag through the outline component tree so
  course-level settings can suppress estimated time rendering.
- Updated SectionTitle and SequenceTitle to render compact minute labels
  next to titles.
- Reused the same estimated-time formatting pattern across Section.tsx,
  SectionTitle.tsx, SequenceLink.tsx, and SequenceTitle.tsx for consistent
  outline presentation.
- Calculated total estimated course time from section and sequence
  effort data.
- Rendered a course-level estimated time label next to the outline
  title when enabled.
- Passed the showEstimatedTime flag through to the section outline
  slot so downstream rows can respect the course setting.
- Added strings for estimated time labels in the course
  outline header, sections, and sequences.
- Introduced minute/hour formatting for outline time estimates.
- Added estimated-time labels to sidebar section, sequence, and unit rows.
- Resolved effort time from outline data and fell back to unit-level
  estimated time where needed.
- Passed the showEstimatedTime flag through the sidebar outline tree
  so course-level settings can hide the estimates.
- Kept the new labels consistent with the existing sidebar
  outline layout.
- Added inline commenting to SidebarSection.jsx,
  SidebarSequence.jsx, and SidebarUnit.jsx.
…ydration

- Updated CourseOutlineTray.jsx to pass showOutlineEstimatedTime through
  section and sequence sidebar components.
- Enhanced hooks.jsx to expose showOutlineEstimatedTime, surface model
  fallback data, and trigger one-time effort hydration after outline load.
- Added compact estimated-time localization in messages.ts for
  consistent sidebar time labels.
- Updated normalizeLearningSequencesData, normalizeSequenceMetadata, and
  normalizeOutlineBlocks to persist effort metadata.
- Added fallback conversion from estimated_time_minutes to seconds when
  effort_time is missing for consistent unit calculations.
- Extended models to include course-level showEstimatedTime
  and course block structure for downstream rendering.
- Added hydrateOutlineEffortData thunk to fetch sequence metadata and backfill missing  unit and sequence effort values.
- Updated CourseHomeSectionOutlineSlot to propagate
  showOutlineEstimatedTime into section rendering.
- Enhanced UnitTitleSlot to show an "Estimated Time to Complete"
  label under the unit title, with proper hour/minute formatting.
- Expanded UnitTitleSlot unit prop typing to include
  estimatedTimeMinutes and showOutlineEstimatedTime for
  downstream consumption.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 13, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @becdavid!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions May 13, 2026
@becdavid becdavid closed this May 13, 2026
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants