feat: update UnitTitleSlot to wrap unit title#1414
Closed
brian-smith-tcril wants to merge 1 commit intoopenedx:masterfrom
Closed
feat: update UnitTitleSlot to wrap unit title#1414brian-smith-tcril wants to merge 1 commit intoopenedx:masterfrom
UnitTitleSlot to wrap unit title#1414brian-smith-tcril wants to merge 1 commit intoopenedx:masterfrom
Conversation
brian-smith-tcril
force-pushed
the
title-slot-wraps-title
branch
from
7432a4e to
13a679f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1414 +/- ##
=======================================
Coverage 88.83% 88.83%
=======================================
Files 307 307
Lines 5268 5268
Branches 1338 1304 -34
=======================================
Hits 4680 4680
Misses 572 572
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kdmccormick
approved these changes
Jul 2, 2024
Member
kdmccormick
left a comment
kdmccormick
left a comment
There was a problem hiding this comment.
Haven't tested manually but LGTM
Contributor
|
@brian-smith-tcril Should we close this PR or do you want to merge it? |
Contributor
Author
|
@bradenmacdonald thanks for reminding me about this PR! I had forgotten about it, and I do still think it's worth landing. |
arbrandes
approved these changes
Mar 5, 2025
Contributor
arbrandes
left a comment
arbrandes
left a comment
There was a problem hiding this comment.
Yeah, I agree it's still worth merging. Just needs a rebase.
Contributor
Author
|
A better version of this landed via #1643 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was reminded this wasn't the case during the workshop when this slide was shown