feat: improved accessibility skipping to main content#1599
feat: improved accessibility skipping to main content#1599vladislavkeblysh wants to merge 1 commit intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @vladislavkeblysh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
8cab1e9 to
5420474
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1599 +/- ##
==========================================
+ Coverage 90.18% 90.24% +0.05%
==========================================
Files 339 339
Lines 5810 5742 -68
Branches 1409 1398 -11
==========================================
- Hits 5240 5182 -58
+ Misses 552 543 -9
+ Partials 18 17 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
38c66ab to
99b5e8e
Compare
|
@vladislavkeblysh Thank you for this contribution! |
6719338 to
2f2b8bb
Compare
|
@vladislavkeblysh Since this PR seems to include user-facing changes, you'll likely need to get product approval for it. When you're ready please follow the instructions from the bot to get that process started. |
|
Hey @vladislavkeblysh, just checking in to see if you're still planning to continue working on this PR? |
7d04658 to
7aee577
Compare
7aee577 to
7493dfb
Compare
|
@itsjeyd Ready to review |
|
@vladislavkeblysh Thanks for the update. Have you been able to get product approval for this change? |
|
[inform]: Awaiting Product Review |
| src={Bookmark} | ||
| className="text-primary small position-absolute" | ||
| style={{ top: '-3px', right: '5px' }} | ||
| style={{ |
There was a problem hiding this comment.
[question]: Can we export these styles to a style file?
| return ( | ||
| <> | ||
| <a href="#main-content" data-testid="skip-link">Skip to content</a> | ||
| {/* Нет #main-content */} |
There was a problem hiding this comment.
[question]: Do we need this?
|
|
||
| import messages from './messages'; | ||
|
|
||
| const MAIN_CONTENT_ID = 'main-content-heading'; |
There was a problem hiding this comment.
[questions]: We use the MAIN_CONTENT_ID constant twice. Does it make sense to put it in a separate constants.js file?
|
Sandbox deployment successful 🚀 |
|
Hi @vladislavkeblysh, just a quick update that I'm closing this PR now because it is stale. You're welcome to reopen this pull request, or open a new one, when you have time to come back to this work. |
Description
Jump user's focus skipping two navigation menus above it
Testing instructions
Progress Page
Course Unit Page
Dates Page
Screen.Recording.2025-05-02.at.16.30.01.mov