feat: added the ability to close the hint using the keyboard#1605
feat: added the ability to close the hint using the keyboard#1605vladislavkeblysh wants to merge 3 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @vladislavkeblysh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1605 +/- ##
==========================================
+ Coverage 90.18% 90.35% +0.16%
==========================================
Files 339 343 +4
Lines 5810 5753 -57
Branches 1409 1382 -27
==========================================
- Hits 5240 5198 -42
+ Misses 552 538 -14
+ Partials 18 17 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
914c375 to
e42a23a
Compare
|
@vladislavkeblysh Thank you for this contribution! Same note about product review here. |
e42a23a to
c8c8168
Compare
|
Hey @vladislavkeblysh, just checking in to see if you're still planning to continue working on this PR? |
c8c8168 to
da56709
Compare
ea41873 to
2f58666
Compare
|
@itsjeyd This PR ready to review |
|
[inform]: Awaiting Product Review |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
|
Some context after accessibility review: When activating the grade summary tooltip, keyboard focus is not placed in the tooltip content. There is no mechanism to close the tooltip using the keyboard. Recommended actions:
|
|
Sandbox deployment successful 🚀 |
|
Hi @vladislavkeblysh, just a quick update that I'm closing this PR now because it is stale. You're welcome to reopen this pull request, or open a new one, when you have time to come back to this work. |
Description
This PR provides a mechanism to close the tooltip using the keyboard. The escape key is recommended
Testing instructions
Screen.Recording.2025-05-02.at.13.28.19.mov