Skip to content

fix: button hover background color#1653

Merged
KristinAoki merged 2 commits intomasterfrom
KristinAoki/fix-top-navigation-button-hover-color
Mar 25, 2025
Merged

fix: button hover background color#1653
KristinAoki merged 2 commits intomasterfrom
KristinAoki/fix-top-navigation-button-hover-color

Conversation

@KristinAoki
Copy link
Copy Markdown
Contributor

Description

This PR updates the hover background for the top navigation buttons that are shown when the left side navigation is enabled. The hover background is updated to match the hover background of other existing IconButton components, see DiscussionNotificationTrigger.jsx, on the page.

Before
Screenshot 2025-03-25 at 12 52 14 PM

After
Screenshot 2025-03-25 at 12 53 51 PM

@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @KristinAoki!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 25, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Mar 25, 2025
@KristinAoki KristinAoki enabled auto-merge (squash) March 25, 2025 17:02
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (226c4cc) to head (207ede8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1653   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files         338      338           
  Lines        5784     5784           
  Branches     1370     1407   +37     
=======================================
  Hits         5211     5211           
+ Misses        557      556    -1     
- Partials       16       17    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KristinAoki KristinAoki merged commit 81b6211 into master Mar 25, 2025
7 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/fix-top-navigation-button-hover-color branch March 25, 2025 17:03
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants