Skip to content

feat: upgrade to react 18#1663

Merged
brian-smith-tcril merged 1 commit intoopenedx:masterfrom
brian-smith-tcril:react-18
Apr 7, 2025
Merged

feat: upgrade to react 18#1663
brian-smith-tcril merged 1 commit intoopenedx:masterfrom
brian-smith-tcril:react-18

Conversation

@brian-smith-tcril
Copy link
Copy Markdown
Contributor

@brian-smith-tcril brian-smith-tcril commented Apr 2, 2025

Part 2 of #1587

@brian-smith-tcril brian-smith-tcril force-pushed the react-18 branch 7 times, most recently from 32cb867 to 6769f69 Compare April 4, 2025 18:19
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (0d45c78) to head (ea4d302).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1663      +/-   ##
==========================================
+ Coverage   90.09%   90.22%   +0.13%     
==========================================
  Files         338      338              
  Lines        5784     5800      +16     
  Branches     1370     1410      +40     
==========================================
+ Hits         5211     5233      +22     
+ Misses        557      550       -7     
- Partials       16       17       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brian-smith-tcril brian-smith-tcril marked this pull request as ready for review April 4, 2025 19:22
@brian-smith-tcril brian-smith-tcril marked this pull request as draft April 4, 2025 19:23
</ul>
</td>
<td dir="auto" />
<td aria-label="todo: what is this? it's causing a jsx-a11y/control-has-associated-label error" dir="auto" />
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: figure out what's up with this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brian-smith-tcril brian-smith-tcril added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Apr 4, 2025
@open-craft-grove
Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@brian-smith-tcril brian-smith-tcril marked this pull request as ready for review April 7, 2025 15:19
@open-craft-grove
Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

Copy link
Copy Markdown
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏼

@brian-smith-tcril brian-smith-tcril merged commit 360af1f into openedx:master Apr 7, 2025
7 checks passed
nsprenkle pushed a commit to edx/frontend-app-learning that referenced this pull request Apr 28, 2025
nsprenkle added a commit to edx/frontend-app-learning that referenced this pull request Apr 28, 2025
jciasenza pushed a commit to jciasenza/frontend-app-learning that referenced this pull request May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants