feat: removes Upgrade Notification as default content#1675
Merged
arbrandes merged 1 commit intoopenedx:masterfrom Apr 14, 2025
Merged
feat: removes Upgrade Notification as default content#1675arbrandes merged 1 commit intoopenedx:masterfrom
arbrandes merged 1 commit intoopenedx:masterfrom
Conversation
arbrandes
force-pushed
the
remove-upgrade-notification
branch
from
0189cbf to
1d73fa7
Compare
arbrandes
commented
Apr 14, 2025
| expect(screen.queryByTestId(testId)).not.toBeInTheDocument(); | ||
| }); | ||
| }); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
These tests can no longer run because they rely on a "Close" button that can now only be provided by a plugin.
(I don't approve of the way this NotificationsWidget was implemented in the first place. It should not have relied on an optional widget for an apparently essential feature. But it's beyond the scope of this PR to fix the architecture here.)
Contributor
Author
|
Picking up #1410 since the original author left the project. @bradenmacdonald and/or @brian-smith-tcril, mind giving this a thumbs up? |
arbrandes
force-pushed
the
remove-upgrade-notification
branch
from
1d73fa7 to
476a02c
Compare
As a follow-up to openedx#1368, remove the UpgradeNotification component from the sidebar's default content.
arbrandes
force-pushed
the
remove-upgrade-notification
branch
from
476a02c to
536625e
Compare
brian-smith-tcril
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to #1368, remove the UpgradeNotification component from the sidebar's default content.