feat: replace edX® certificate icons#1687
Conversation
|
Thanks for the pull request, @Cup0fCoffee! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
4d05717 to
2fc9083
Compare
|
@Cup0fCoffee I invited you to the Triage group in Open edX so that tests will run for you :) please accept the invite :)) |
|
Also I am not a committer for frontend repos so I've requested a review from @brian-smith-tcril - Brian, this is approved by product and looks fine to me but want second 👀 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1687 +/- ##
=======================================
Coverage 90.20% 90.20%
=======================================
Files 343 343
Lines 5747 5747
Branches 1381 1381
=======================================
Hits 5184 5184
+ Misses 546 544 -2
- Partials 17 19 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Old certificates icons contained edX trademark logos, which were not suitable for the open source repos. Replaced with icons that contain Open edX logos.
2fc9083 to
61a50bd
Compare
|
@Cup0fCoffee do you have the time to backport this one to Teak as well? |
|
|
Hey 👋 Wanted to request a refactor on this. I would argue that these branded assets should be part of the brand package, not the Learning MFE, and should be moved there. This rename actually breaks a bunch of plugins and dependences we have that were looking for the old certificate names, which could be avoided entirely if it were an aliased brand asset (e.g. "certificate_locked.png") instead. |
|
@nsprenkle, that makes complete sense to me. I have a feeling this feature deserves a good re-think, though, including bringing in some product heads. It should've been configurable/overridable from the start. |
Description
Fixes openedx/platform-roadmap#425
This PR replaces the icons for the certificates. Old certificates icons contained edX trademark logos, which were not suitable for the open source repos. Replaced with icons that contain Open edX logos.