Skip to content

feat: replace edX® certificate icons#1687

Merged
arbrandes merged 1 commit intoopenedx:masterfrom
open-craft:maxim/bb-9475-replace-certificate-icons
Apr 30, 2025
Merged

feat: replace edX® certificate icons#1687
arbrandes merged 1 commit intoopenedx:masterfrom
open-craft:maxim/bb-9475-replace-certificate-icons

Conversation

@Cup0fCoffee
Copy link
Copy Markdown
Contributor

Description

Fixes openedx/platform-roadmap#425

This PR replaces the icons for the certificates. Old certificates icons contained edX trademark logos, which were not suitable for the open source repos. Replaced with icons that contain Open edX logos.

@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @Cup0fCoffee!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@sarina
Copy link
Copy Markdown
Contributor

sarina commented Apr 25, 2025

@Cup0fCoffee I invited you to the Triage group in Open edX so that tests will run for you :) please accept the invite :))

@sarina sarina moved this from Needs Triage to Ready for Review in Contributions Apr 25, 2025
@sarina
Copy link
Copy Markdown
Contributor

sarina commented Apr 25, 2025

Also I am not a committer for frontend repos so I've requested a review from @brian-smith-tcril - Brian, this is approved by product and looks fine to me but want second 👀

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (24c9437) to head (61a50bd).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1687   +/-   ##
=======================================
  Coverage   90.20%   90.20%           
=======================================
  Files         343      343           
  Lines        5747     5747           
  Branches     1381     1381           
=======================================
  Hits         5184     5184           
+ Misses        546      544    -2     
- Partials       17       19    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Old certificates icons contained edX trademark logos, which were not
suitable for the open source repos. Replaced with icons that contain
Open edX logos.
@Cup0fCoffee Cup0fCoffee force-pushed the maxim/bb-9475-replace-certificate-icons branch from 2fc9083 to 61a50bd Compare April 29, 2025 13:42
Copy link
Copy Markdown
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@sarina
Copy link
Copy Markdown
Contributor

sarina commented Apr 30, 2025

@Cup0fCoffee do you have the time to backport this one to Teak as well?

@arbrandes arbrandes merged commit 1412bfe into openedx:master Apr 30, 2025
7 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions Apr 30, 2025
@Cup0fCoffee Cup0fCoffee deleted the maxim/bb-9475-replace-certificate-icons branch April 30, 2025 14:04
@Cup0fCoffee
Copy link
Copy Markdown
Contributor Author

@Cup0fCoffee do you have the time to backport this one to Teak as well?

@sarina Done - #1693

@nsprenkle
Copy link
Copy Markdown
Contributor

Hey 👋 Wanted to request a refactor on this. I would argue that these branded assets should be part of the brand package, not the Learning MFE, and should be moved there.

This rename actually breaks a bunch of plugins and dependences we have that were looking for the old certificate names, which could be avoided entirely if it were an aliased brand asset (e.g. "certificate_locked.png") instead.

@arbrandes
Copy link
Copy Markdown
Contributor

@nsprenkle, that makes complete sense to me. I have a feeling this feature deserves a good re-think, though, including bringing in some product heads. It should've been configurable/overridable from the start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Remove icons with edX® trademark logos from OpenSource repositories

5 participants