fix(docs): backport #1688 and #1689#1690
fix(docs): backport #1688 and #1689#1690brian-smith-tcril wants to merge 2 commits intoopenedx:release/teak.masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/teak.master #1690 +/- ##
====================================================
Coverage 90.20% 90.20%
====================================================
Files 343 343
Lines 5747 5747
Branches 1381 1381
====================================================
Hits 5184 5184
+ Misses 546 544 -2
- Partials 17 19 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
farhaanbukhsh
left a comment
There was a problem hiding this comment.
👍
- ✅ I read through the code
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
|
@bradenmacdonald @farhaanbukhsh: this PR was closed when the release branch changed to release/teak. Should we reopen it? |
|
@mariajgrimaldi Good catch! We do still need this fix (see e.g. https://github.com/openedx/frontend-app-learning/blob/release/teak/src/plugin-slots/CourseRecommendationsSlot/README.md which has the wrong title) but it's impossible to re-open this PR. If you or @brian-smith-tcril could re-open a new PR against the new teak branch with the same changes, I'll approve and merge it. |
|
Made the new PR #1765 |
No description provided.