Skip to content

fix(docs): backport #1688 and #1689#1690

Closed
brian-smith-tcril wants to merge 2 commits intoopenedx:release/teak.masterfrom
brian-smith-tcril:backport-docs-fixes
Closed

fix(docs): backport #1688 and #1689#1690
brian-smith-tcril wants to merge 2 commits intoopenedx:release/teak.masterfrom
brian-smith-tcril:backport-docs-fixes

Conversation

@brian-smith-tcril
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (24c9437) to head (b9efc66).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           release/teak.master    #1690   +/-   ##
====================================================
  Coverage                90.20%   90.20%           
====================================================
  Files                      343      343           
  Lines                     5747     5747           
  Branches                  1381     1381           
====================================================
  Hits                      5184     5184           
+ Misses                     546      544    -2     
- Partials                    17       19    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@farhaanbukhsh farhaanbukhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • ✅ I read through the code
  • ✅ I read through the code
  • ❌ I checked for accessibility issues
  • ❌ Includes documentation

@farhaanbukhsh farhaanbukhsh deleted the branch openedx:release/teak.master May 19, 2025 15:58
@mariajgrimaldi
Copy link
Copy Markdown
Member

@bradenmacdonald @farhaanbukhsh: this PR was closed when the release branch changed to release/teak. Should we reopen it?

@bradenmacdonald
Copy link
Copy Markdown
Contributor

@mariajgrimaldi Good catch! We do still need this fix (see e.g. https://github.com/openedx/frontend-app-learning/blob/release/teak/src/plugin-slots/CourseRecommendationsSlot/README.md which has the wrong title) but it's impossible to re-open this PR. If you or @brian-smith-tcril could re-open a new PR against the new teak branch with the same changes, I'll approve and merge it.

@brian-smith-tcril
Copy link
Copy Markdown
Contributor Author

Made the new PR #1765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants