Skip to content

feat(teak): update certificate icons#1693

Merged
farhaanbukhsh merged 1 commit intoopenedx:release/teak.masterfrom
open-craft:maxim/bb-9475-replace-certificate-icons-teak
May 5, 2025
Merged

feat(teak): update certificate icons#1693
farhaanbukhsh merged 1 commit intoopenedx:release/teak.masterfrom
open-craft:maxim/bb-9475-replace-certificate-icons-teak

Conversation

@Cup0fCoffee
Copy link
Copy Markdown
Contributor

Backport of #1687

Old certificates icons contained edX trademark logos, which were not
suitable for the open source repos. Replaced with icons that contain
Open edX logos.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 30, 2025
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @Cup0fCoffee!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@Cup0fCoffee
Copy link
Copy Markdown
Contributor Author

@arbrandes @sarina here is the Teak backport.

Copy link
Copy Markdown
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farhaanbukhsh if you agree this can be merged into Teak, could you please perform the merge? Thank you!

Copy link
Copy Markdown
Member

@farhaanbukhsh farhaanbukhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • ✅ I tested this locally and it works fine.
  • ✅ I read through the code
  • ❌ I checked for accessibility issues
  • ❌ Includes documentation

@farhaanbukhsh farhaanbukhsh merged commit 241e188 into openedx:release/teak.master May 5, 2025
13 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions May 5, 2025
@itsjeyd itsjeyd added core contributor PR author is a Core Contributor (who may or may not have write access to this repo). backport PR backports a change from main to a named release. labels May 8, 2025
@itsjeyd itsjeyd removed the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants