Skip to content

Commit 6d0ae1c

Browse files
authored
Merge pull request #30 from davidjoy/main
feat: Adding runtime module management and updating code from source repositories
2 parents 7efcebc + cc9ea02 commit 6d0ae1c

141 files changed

Lines changed: 3095 additions & 17717 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.eslintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const config = require('./tools/eslint/.eslintrc.js');
55

66
module.exports = merge(config, {
77
ignorePatterns: [
8-
'test-app',
8+
'test-project',
99
'docs',
1010
'.eslintrc.js',
1111
'frontend-base.d.ts',

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
npm run build
2727
npm pack
2828
mv openedx-frontend-base* openedx-frontend-base.tgz
29-
cd test-app
29+
cd test-project
3030
npm i ../openedx-frontend-base.tgz
3131
npm ci
3232
- name: Lint

README.md

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ Description fields are now required on all i18n messages in the repository. Thi
343343

344344
### 12. SVGR "ReactComponent" imports have been removed.
345345

346-
We have removed the `@svgr/webpack` loader because it was incompatible with more modern tooling (it requires Babel). As a result, the ability to import SVG files into JS as the `ReactComponent` export no longer works. We know of a total of 5 places where this is happening today in Open edX MFEs - frontend-app-learning and frontend-app-profile use it. Please replace that export with the default URL export and set the URL as the source of an `<img>` tag, rather than using `ReactComponent`. You can see an example of normal SVG imports in `test-app/src/App.jsx`.
346+
We have removed the `@svgr/webpack` loader because it was incompatible with more modern tooling (it requires Babel). As a result, the ability to import SVG files into JS as the `ReactComponent` export no longer works. We know of a total of 5 places where this is happening today in Open edX MFEs - frontend-app-learning and frontend-app-profile use it. Please replace that export with the default URL export and set the URL as the source of an `<img>` tag, rather than using `ReactComponent`. You can see an example of normal SVG imports in `test-project/src/ExamplePage.tsx`.
347347

348348
### 13. Import `createConfig` and `getBaseConfig` from `@openedx/frontend-base/config`
349349

@@ -422,7 +422,7 @@ You must then import this new stylesheet into your `site.config` file:
422422
```diff
423423
+ import './project.scss';
424424

425-
const config: SiteConfig = {
425+
const config: ProjectSiteConfig = {
426426
// config document
427427
}
428428

@@ -443,6 +443,15 @@ Then work through the conflicts and use a merge commit to add the history into t
443443

444444
Then move the files out of the way (move src to some other sub-dir, mostly) to make room for the next repo.
445445

446+
### Latest repository merges
447+
448+
- frontend-component-header - Up to date as of 9/12/2024
449+
- frontend-component-footer - Up to date as of 9/12/2024
450+
- frontend-build - Up to date as of 9/12/2024
451+
452+
- frontend-platform - Up to date as of 9/13/2024
453+
- frontend-plugin-framework - Up to date as of 9/13/2024
454+
446455
# Other notable changes
447456

448457
- Cease using `AUTHN_MINIMAL_HEADER`, replace it with an actual minimal header.

example-plugin-app/package-lock.json

Lines changed: 15 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example-plugin-app/src/DefaultIframe.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { Plugin } from '@openedx/frontend-plugin-framework';
66
function DefaultComponent() {
77
return (
88
<section className="bg-light p-3 h-100">
9-
<h3>Default iFrame Widget</h3>
9+
<h4>Default iFrame Widget</h4>
1010
<p>
1111
This is a component that lives in the example-plugins-app and is provided in this host MFE via iFrame.
1212
</p>
@@ -17,7 +17,7 @@ function DefaultComponent() {
1717
function ErrorFallback(error) {
1818
return (
1919
<div className="text-center">
20-
<p className="h3 text-muted">
20+
<p className="h4 text-muted">
2121
Oops! An error occurred. Please refresh the screen to try again.
2222
</p>
2323
<br />

example-plugin-app/src/PluginIframe.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ export default function PluginIframe() {
55
return (
66
<Plugin>
77
<section className="bg-light p-3 h-100">
8-
<h3>Inserted iFrame Plugin</h3>
8+
<h4>Inserted iFrame Plugin</h4>
99
<p>
1010
This is a component that lives in the example-plugins-app and is provided in this host MFE via iFrame plugin.
1111
</p>

example/.eslintignore

Lines changed: 0 additions & 3 deletions
This file was deleted.

example/.eslintrc.js

Lines changed: 0 additions & 15 deletions
This file was deleted.

example/assets/.gitkeep

Whitespace-only changes.

example/data/.gitkeep

Whitespace-only changes.

0 commit comments

Comments
 (0)