fix: show hydrated profile avatars in Studio header

Co-authored-by: Codex <codex@openai.com>

Author: 2 people

src/studio-header/StudioHeader.test.tsx

@@ -122,6 +122,53 @@ describe('Header', () => {
       expect(avatarIcon).toBeVisible();
     });
 
+    it('user menu should use avatar icon when hydrated profile image has no image', async () => {
+      currentUser = {
+        ...authenticatedUser,
+        avatar: null,
+        profileImage: {
+          hasImage: false,
+          imageUrlMedium: '/profile-images/abc123-medium.png',
+        },
+      };
+      const { getByTestId, queryByTestId } = render(<RootWrapper {...props} />);
+      const avatarIcon = getByTestId('avatar-icon');
+
+      expect(avatarIcon).toBeVisible();
+      expect(queryByTestId('avatar-image')).not.toBeInTheDocument();
+    });
+
+    it('user menu should use hydrated profile image when avatar is not present', async () => {
+      currentUser = {
+        ...authenticatedUser,
+        avatar: null,
+        profileImage: {
+          hasImage: true,
+          imageUrlMedium: '/profile-images/abc123-medium.png',
+        },
+      };
+      const { getByTestId } = render(<RootWrapper {...props} />);
+      const avatarImage = getByTestId('avatar-image');
+
+      expect(avatarImage).toBeVisible();
+      expect(avatarImage).toHaveAttribute('src', '/profile-images/abc123-medium.png');
+    });
+
+    it('user menu should prefer avatar over hydrated profile image', async () => {
+      currentUser = {
+        ...authenticatedUser,
+        profileImage: {
+          hasImage: true,
+          imageUrlMedium: '/profile-images/abc123-medium.png',
+        },
+      };
+      const { getByTestId } = render(<RootWrapper {...props} />);
+      const avatarImage = getByTestId('avatar-image');
+
+      expect(avatarImage).toBeVisible();
+      expect(avatarImage).toHaveAttribute('src', authenticatedUser.avatar);
+    });
+
     it('should hide nav items if prop isHiddenMainMenu true', async () => {
       const initialProps = { ...props, isHiddenMainMenu: true };
       const { queryByTestId } = render(<RootWrapper {...initialProps} />);

src/studio-header/StudioHeader.tsx

@@ -40,6 +40,9 @@ const StudioHeader: FunctionComponent<Props> = ({
 }) => {
   // @ts-expect-error - frontend-platform doesn't yet have type information :/
   const { authenticatedUser, config } = useContext(AppContext);
+  const profileImage = authenticatedUser?.profileImage;
+  const authenticatedUserAvatar = authenticatedUser?.avatar
+    || (profileImage?.hasImage ? profileImage.imageUrlMedium : null);
   const props = {
     logo: config.LOGO_URL,
     logoAltText: `Studio ${config.SITE_NAME}`,
@@ -49,7 +52,7 @@ const StudioHeader: FunctionComponent<Props> = ({
     containerProps,
     username: authenticatedUser?.username,
     isAdmin: authenticatedUser?.administrator,
-    authenticatedUserAvatar: authenticatedUser?.avatar,
+    authenticatedUserAvatar,
     studioBaseUrl: isNewHomePage ? '/home' : config.STUDIO_BASE_URL,
     logoutUrl: config.LOGOUT_URL,
     isHiddenMainMenu,