Skip to content

Commit b909372

Browse files
author
Adam Stankiewicz
authored
feat: add logo URLs to app config (#132)
* feat: add logo URLs to AppContext config * Add LOGO_* and FAVICON_URL config in other places
1 parent 195e31a commit b909372

4 files changed

Lines changed: 20 additions & 0 deletions

File tree

.env.development

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,7 @@ REFRESH_ACCESS_TOKEN_ENDPOINT=http://localhost:18000/login_refresh
1717
SEGMENT_KEY=ul
1818
SITE_NAME=Open edX
1919
USER_INFO_COOKIE_NAME=edx-user-info
20+
LOGO_URL=https://edx-cdn.org/v3/default/logo.svg
21+
LOGO_TRADEMARK_URL=https://edx-cdn.org/v3/default/logo-trademark.svg
22+
LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg
23+
FAVICON_URL=https://edx-cdn.org/v3/default/favicon.ico

.env.test

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,7 @@ REFRESH_ACCESS_TOKEN_ENDPOINT=http://localhost:18000/login_refresh
1717
SEGMENT_KEY=ul
1818
SITE_NAME=Open edX
1919
USER_INFO_COOKIE_NAME=edx-user-info
20+
LOGO_URL=https://edx-cdn.org/v3/default/logo.svg
21+
LOGO_TRADEMARK_URL=https://edx-cdn.org/v3/default/logo-trademark.svg
22+
LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg
23+
FAVICON_URL=https://edx-cdn.org/v3/default/favicon.ico

src/config.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,10 @@ let config = {
5252
SEGMENT_KEY: process.env.SEGMENT_KEY,
5353
SITE_NAME: process.env.SITE_NAME,
5454
USER_INFO_COOKIE_NAME: process.env.USER_INFO_COOKIE_NAME,
55+
LOGO_URL: process.env.LOGO_URL,
56+
LOGO_TRADEMARK_URL: process.env.LOGO_TRADEMARK_URL,
57+
LOGO_WHITE_URL: process.env.LOGO_WHITE_URL,
58+
FAVICON_URL: process.env.FAVICON_URL,
5559
};
5660

5761
/**
@@ -172,4 +176,8 @@ export function ensureConfig(keys, requester = 'unspecified application code') {
172176
* @property {string} SEGMENT_KEY
173177
* @property {string} SITE_NAME
174178
* @property {string} USER_INFO_COOKIE_NAME
179+
* @property {string} LOGO_URL
180+
* @property {string} LOGO_TRADEMARK_URL
181+
* @property {string} LOGO_WHITE_URL
182+
* @property {string} FAVICON_URL
175183
*/

src/setupTest.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ process.env.REFRESH_ACCESS_TOKEN_ENDPOINT = 'http://localhost:18000/login_refres
2626
process.env.SEGMENT_KEY = 'segment_whoa';
2727
process.env.SITE_NAME = 'edX';
2828
process.env.USER_INFO_COOKIE_NAME = 'edx-user-info';
29+
process.env.LOGO_URL = 'https://edx-cdn.org/v3/default/logo.svg';
30+
process.env.LOGO_TRADEMARK_URL = 'https://edx-cdn.org/v3/default/logo-trademark.svg';
31+
process.env.LOGO_WHITE_URL = 'https://edx-cdn.org/v3/default/logo-white.svg';
32+
process.env.FAVICON_URL = 'https://edx-cdn.org/v3/default/favicon.ico';
2933

3034
/* Auth test variables
3135

0 commit comments

Comments
 (0)