fix: set document title via Helmet on the template route#1000
Merged
arbrandes merged 1 commit intoopenedx:frontend-basefrom Apr 29, 2026
Merged
fix: set document title via Helmet on the template route#1000arbrandes merged 1 commit intoopenedx:frontend-basefrom
arbrandes merged 1 commit intoopenedx:frontend-basefrom
Conversation
Adopt the per-page document title pattern from frontend-base ADR 0015, so apps generated from this template ship with a sensible browser-tab title instead of inheriting the previous app's. Since frontend-base's migration how-to points to this repo for complete examples, including the pattern here also makes it discoverable for new apps. Refs openedx/frontend-base#250. Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## frontend-base #1000 +/- ##
==================================================
+ Coverage 0.00% 27.27% +27.27%
==================================================
Files 8 9 +1
Lines 20 22 +2
Branches 1 1
==================================================
+ Hits 0 6 +6
+ Misses 20 16 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brian-smith-tcril
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs openedx/frontend-base#250.
Adopts the per-page document title pattern set out in frontend-base ADR 0015. The template's
Mainroute component now renders a<Helmet>block that sets<title>from a new localized message (template.page.title, defaultTemplate | {siteName}), withsiteNamepulled fromgetSiteConfig()and passed as an i18n parameter.react-helmetis added to runtime dependencies, and a small test asserts thatdocument.titleends up as expected.This matters for the template specifically because frontend-base's migration how-to points here for complete examples, so apps following the migration path will land on the right pattern by default.
LLM usage notice
Built with assistance from Claude.