Conversation
4 tasks
arbrandes
force-pushed
the
frontend-base
branch
2 times, most recently
from
0c86523 to
0dc7444
Compare
Follows the frontend-base migration how-to to turn this template into a library that plugs into the Open edX frontend shell, rather than a standalone webpack-bundled MFE. Co-Authored-By: Claude <noreply@anthropic.com>
arbrandes
force-pushed
the
frontend-base
branch
from
f511d00 to
1bbac69
Compare
arbrandes
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #906 +/- ##
===========================================
+ Coverage 0.00% 27.27% +27.27%
===========================================
Files 3 9 +6
Lines 24 22 -2
Branches 0 1 +1
===========================================
+ Hits 0 6 +6
+ Misses 24 16 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
PR updated for frontend-base 1.0.0 (aka Verawood). |
Adopt the per-page document title pattern from frontend-base ADR 0015, so apps generated from this template ship with a sensible browser-tab title instead of inheriting the previous app's. Since frontend-base's migration how-to points to this repo for complete examples, including the pattern here also makes it discoverable for new apps. Refs openedx/frontend-base#250. Co-Authored-By: Claude <noreply@anthropic.com>
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refer to the parent issue for a full description.
In short, this refactors the codebase for frontend-base support. There are several breaking changes. It is a long-lived feature branch, and as such, should not be rebased or squashed until time comes for it to either merge to master or become master.