Skip to content

Commit 191c26e

Browse files
arbrandesclaude
andcommitted
fix: conform site.scss to new frontend-base CSS ownership model
Move site.scss to the repo root and stop re-importing app stylesheets: per the updated frontend-base guidance, the composing site owns global styles and apps manage their own. Use @openedx/brand-openedx directly (no need for an alias since package.json and site.scss are themselves configuration), and bump it to v2. Also add notificationsApp to the site configs. Co-Authored-By: Claude <noreply@anthropic.com>
1 parent ffc35dd commit 191c26e

5 files changed

Lines changed: 10 additions & 7 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
]
4141
},
4242
"dependencies": {
43-
"@edx/brand": "npm:@openedx/brand-openedx@^1.2.3",
43+
"@openedx/brand-openedx": "^2.0.0",
4444
"@openedx/frontend-app-authn": "^1.0.0-alpha || 0.0.0-dev",
4545
"@openedx/frontend-app-learner-dashboard": "^1.0.0-alpha || 0.0.0-dev",
4646
"@openedx/frontend-app-instructor-dashboard": "^1.0.0-alpha || 0.0.0-dev",

site.config.build.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@ import { EnvironmentTypes, SiteConfig, footerApp, headerApp, shellApp } from '@o
22
import { authnApp } from '@openedx/frontend-app-authn';
33
import { instructorDashboardApp } from '@openedx/frontend-app-instructor-dashboard';
44
import { learnerDashboardApp } from '@openedx/frontend-app-learner-dashboard';
5+
import { notificationsApp } from '@openedx/frontend-app-notifications';
56

6-
import './src/site.scss';
7+
import './site.scss';
78

89
const siteConfig: SiteConfig = {
910
siteId: 'frontend-template-site',
@@ -21,6 +22,7 @@ const siteConfig: SiteConfig = {
2122
authnApp,
2223
learnerDashboardApp,
2324
instructorDashboardApp,
25+
notificationsApp,
2426
],
2527
externalRoutes: [
2628
{

site.config.dev.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@ import { EnvironmentTypes, SiteConfig, footerApp, headerApp, shellApp } from '@o
22
import { authnApp } from '@openedx/frontend-app-authn';
33
import { instructorDashboardApp } from '@openedx/frontend-app-instructor-dashboard';
44
import { learnerDashboardApp } from '@openedx/frontend-app-learner-dashboard';
5+
import { notificationsApp } from '@openedx/frontend-app-notifications';
56

6-
import './src/site.scss';
7+
import './site.scss';
78

89
const siteConfig: SiteConfig = {
910
siteId: 'frontend-template-dev',
@@ -21,6 +22,7 @@ const siteConfig: SiteConfig = {
2122
authnApp,
2223
learnerDashboardApp,
2324
instructorDashboardApp,
25+
notificationsApp,
2426
],
2527
externalRoutes: [
2628
{

site.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
@use '@openedx/frontend-base/shell/app.scss' as shell;
2+
@use '@openedx/brand-openedx/core.min.css';
3+
@use '@openedx/brand-openedx/light.min.css';

src/site.scss

Lines changed: 0 additions & 4 deletions
This file was deleted.

0 commit comments

Comments
 (0)