fix: conform site.scss to new frontend-base CSS ownership model#14
Merged
Conversation
Per the updated frontend-base guidance, the composing site owns global styles and apps manage their own. Imports the shell style manifest (@openedx/frontend-base/shell/style) and brand CSS directly from the site.config files, removing the intermediate site.scss. Uses @openedx/brand-openedx directly (no need for an alias since package.json and the site configs are themselves configuration), and bumps it to v2. Also adds notificationsApp to the site configs. Co-Authored-By: Claude <noreply@anthropic.com>
brian-smith-tcril
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Conforms to the updated CSS ownership model in
frontend-base, where the composing site owns global styles and apps manage their own. Imports the shell style manifest (@openedx/frontend-base/shell/style) and brand CSS directly from thesite.config.*.tsxfiles, removing the intermediatesrc/site.scss.Uses
@openedx/brand-openedxdirectly instead of the@edx/brandalias (no need for the alias sincepackage.jsonand the site configs are themselves configuration), and bumps it to v2.Also adds
notificationsAppto both the build and dev site configs.TODO
Needs a package-lock update once the apps have been updated themselves.
LLM usage notice
Built with assistance from Claude.