fix(squash): derive entity_ref from code fields, don't accept it as a parameter

Container and component creation functions no longer accept entity_ref.
It is always derived: containers use container_code, components use
"{namespace}:{type_name}:{component_code}". Only the low-level
create_publishable_entity() still accepts entity_ref directly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: kdmccormick

src/openedx_content/applets/backup_restore/zipper.py

@@ -836,7 +836,6 @@ def _save_container(
             container = containers_api.create_container(
                 learning_package.id,
                 **data,  # should this be allowed to override any of the following fields?
-                entity_ref=entity_ref,
                 created_by=self.user_id,
                 container_cls=container_cls,
             )

src/openedx_content/applets/components/api.py

@@ -82,16 +82,14 @@ def create_component(
     created_by: int | None,
     *,
     can_stand_alone: bool = True,
-    entity_ref: str | None = None,
 ) -> Component:
     """
     Create a new Component (an entity like a Problem or Video).
 
-    If ``entity_ref`` is not provided, it defaults to
+    The ``entity_ref`` is always derived as
     ``"{namespace}:{type_name}:{component_code}"``.
     """
-    if entity_ref is None:
-        entity_ref = f"{component_type.namespace}:{component_type.name}:{component_code}"
+    entity_ref = f"{component_type.namespace}:{component_type.name}:{component_code}"
     with atomic():
         publishable_entity = publishing_api.create_publishable_entity(
             learning_package_id,
@@ -282,13 +280,9 @@ def create_component_and_version(  # pylint: disable=too-many-positional-argumen
     created_by: int | None = None,
     *,
     can_stand_alone: bool = True,
-    entity_ref: str | None = None,
 ) -> tuple[Component, ComponentVersion]:
     """
     Create a Component and associated ComponentVersion atomically.
-
-    If ``entity_ref`` is not provided, it defaults to
-    ``"{namespace}:{type_name}:{component_code}"``.
     """
     with atomic():
         component = create_component(
@@ -298,7 +292,6 @@ def create_component_and_version(  # pylint: disable=too-many-positional-argumen
             created,
             created_by,
             can_stand_alone=can_stand_alone,
-            entity_ref=entity_ref,
         )
         component_version = create_component_version(
             component.id,

src/openedx_content/applets/containers/api.py

@@ -142,7 +142,6 @@ def create_container(
     container_code: str,
     container_cls: type[ContainerModel],
     can_stand_alone: bool = True,
-    entity_ref: str | None = None,
 ) -> ContainerModel:
     """
     [ 🛑 UNSTABLE ]
@@ -156,17 +155,13 @@ def create_container(
             the learning package (regardless of container type).
         container_cls: The subclass of container to create (e.g. `Unit`)
         can_stand_alone: Set to False when created as part of containers
-        entity_ref: Optional opaque reference string. Defaults to container_code.
-            # TODO: The dev team is considering revisiting the default container
-            # entity_ref derivation in the future.
 
     Returns:
         The newly created container as an instance of `container_cls`.
     """
     assert issubclass(container_cls, Container)
     assert container_cls is not Container, "Creating plain containers is not allowed; use a subclass of Container"
-    if entity_ref is None:
-        entity_ref = container_code  # TODO: The team may revisit this default derivation.
+    entity_ref = container_code
     with atomic():
         publishable_entity = publishing_api.create_publishable_entity(
             learning_package_id,
@@ -356,7 +351,6 @@ def create_container_and_version(
     created: datetime,
     created_by: int | None = None,
     can_stand_alone: bool = True,
-    entity_ref: str | None = None,
 ) -> tuple[ContainerModel, ContainerVersionModel]:
     """
     [ 🛑 UNSTABLE ] Create a new container and its initial version.
@@ -375,7 +369,6 @@ def create_container_and_version(
         created: The creation date.
         created_by: The ID of the user who created the container.
         can_stand_alone: Set to False when created as part of containers
-        entity_ref: Optional opaque reference string. Defaults to container_code.
     """
     with atomic(savepoint=False):
         container = create_container(
@@ -385,7 +378,6 @@ def create_container_and_version(
             container_code=container_code,
             can_stand_alone=can_stand_alone,
             container_cls=container_cls,
-            entity_ref=entity_ref,
         )
         container_version: ContainerVersionModel = create_container_version(  # type: ignore[assignment]
             container.id,

src/openedx_content/applets/sections/api.py

@@ -38,7 +38,6 @@ def create_section_and_version(
     created: datetime,
     created_by: int | None = None,
     can_stand_alone: bool = True,
-    entity_ref: str | None = None,
 ) -> tuple[Section, SectionVersion]:
     """
     See documentation of `content_api.create_container_and_version()`
@@ -50,7 +49,6 @@ def create_section_and_version(
     section, sv = containers_api.create_container_and_version(
         learning_package_id,
         container_code=container_code,
-        entity_ref=entity_ref,
         title=title,
         entities=subsections,
         created=created,

src/openedx_content/applets/subsections/api.py

@@ -38,7 +38,6 @@ def create_subsection_and_version(
     created: datetime,
     created_by: int | None = None,
     can_stand_alone: bool = True,
-    entity_ref: str | None = None,
 ) -> tuple[Subsection, SubsectionVersion]:
     """
     See documentation of `content_api.create_container_and_version()`
@@ -50,7 +49,6 @@ def create_subsection_and_version(
     subsection, sv = containers_api.create_container_and_version(
         learning_package_id,
         container_code=container_code,
-        entity_ref=entity_ref,
         title=title,
         entities=units,
         created=created,

src/openedx_content/applets/units/api.py

@@ -38,7 +38,6 @@ def create_unit_and_version(
     created: datetime,
     created_by: int | None = None,
     can_stand_alone: bool = True,
-    entity_ref: str | None = None,
 ) -> tuple[Unit, UnitVersion]:
     """
     See documentation of `content_api.create_container_and_version()`
@@ -50,7 +49,6 @@ def create_unit_and_version(
     unit, uv = containers_api.create_container_and_version(
         learning_package_id,
         container_code=container_code,
-        entity_ref=entity_ref,
         title=title,
         entities=components,
         created=created,