fix: PR review comments

Author: jesperhodge

src/openedx_tagging/signal_handlers.py

@@ -1,5 +1,7 @@
 """Signal handlers for tagging-related model updates."""
 
+from functools import partial
+
 from django.db import transaction
 from django.db.models.signals import post_save
 from django.dispatch import receiver
@@ -23,5 +25,8 @@ def tag_post_save(sender, **kwargs):  # pylint: disable=unused-argument
         return
 
     transaction.on_commit(
-        lambda: emit_content_object_associations_changed_for_tag_task.delay(tag_id)
+        partial(
+            emit_content_object_associations_changed_for_tag_task.delay,
+            tag_id=tag_id
+        )
     )

src/openedx_tagging/tasks.py

@@ -12,7 +12,11 @@
 
 
 def _emit_content_object_associations_changed_for_tag(tag: Tag) -> int:
-    """Emit CONTENT_OBJECT_ASSOCIATIONS_CHANGED for each object associated with the given tag."""
+    """
+    Emit CONTENT_OBJECT_ASSOCIATIONS_CHANGED events for each content object linked to this tag
+    via the ObjectTag assciations. This is used to trigger downstream updates
+    like search index refreshes in Meilisearch.
+    """
     object_ids = ObjectTag.objects.filter(tag=tag).values_list("object_id", flat=True)
     emitted_events = 0
 
@@ -37,7 +41,12 @@ def _emit_content_object_associations_changed_for_tag(tag: Tag) -> int:
 
 @shared_task
 def emit_content_object_associations_changed_for_tag_task(tag_id: int) -> int:
-    """Emit content association changed events for all objects linked to the given tag id."""
+    """
+    When a tag is updated, emit a CONTENT_OBJECT_ASSOCIATIONS_CHANGED event for every ObjectTag linked to that tag.
+    Each ObjectTag represents an association between the tag and an Open edX object.
+    Because downstream systems (for example, search indexes such as Meilisearch) index object-tag relationships,
+    they must be notified so they can refresh the object's association data.
+    """
     try:
         tag = Tag.objects.get(pk=tag_id)
     except Tag.DoesNotExist:

tests/openedx_tagging/test_models.py

@@ -1154,7 +1154,7 @@ def test_rename_updates_search_index(self, mock_task_delay) -> None:
             self.alice.save()
 
         assert mock_task_delay.call_count == 1
-        assert mock_task_delay.call_args[0][0] == self.alice.id
+        assert mock_task_delay.call_args[1]['tag_id'] == self.alice.id
 
     @patch("openedx_tagging.tasks.CONTENT_OBJECT_ASSOCIATIONS_CHANGED", new_callable=MagicMock)
     def test_emit_content_object_associations_changed_for_tag_task(self, mock_signal) -> None: