Skip to content

Commit 130d3ba

Browse files
fixup! feat: extract overridable permission methods from ObjectTagView
1 parent 6c6a251 commit 130d3ba

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

src/openedx_tagging/rest_api/v1/views.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,6 +450,8 @@ class ObjectTagView(
450450
serializer_class = ObjectTagSerializer
451451
# Serializer used in the result in `to_representation` in `ObjectTagsByTaxonomySerializer`
452452
minimal_serializer_class = ObjectTagMinimalSerializer
453+
# Serializer used in `retrieve` to group object tags by taxonomy
454+
taxonomy_serializer_class = ObjectTagsByTaxonomySerializer
453455
permission_classes = [ObjectTagObjectPermissions]
454456
lookup_field = "object_id"
455457
lookup_value_regex = r'[\w\.\+\-@:]+'
@@ -524,7 +526,7 @@ def retrieve(self, request, *args, **kwargs) -> Response:
524526
behavior we want.
525527
"""
526528
object_tags = self.filter_queryset(self.get_queryset())
527-
serializer = ObjectTagsByTaxonomySerializer(list(object_tags), context=self.get_serializer_context())
529+
serializer = self.taxonomy_serializer_class(list(object_tags), context=self.get_serializer_context())
528530
response_data = serializer.data
529531
if self.kwargs["object_id"] not in response_data:
530532
# For consistency, the key with the object_id should always be present in the response, even if there

0 commit comments

Comments
 (0)