Skip to content

Commit ddbae25

Browse files
committed
fix: order previous entity list by order number
1 parent e1222ea commit ddbae25

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

  • openedx_learning/apps/authoring/publishing

openedx_learning/apps/authoring/publishing/api.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -806,7 +806,10 @@ def create_next_entity_list(
806806
entity_version_pks: list[int | None] = [None] * len(publishable_entities_pks) # type: ignore[no-redef]
807807
if entities_action == ChildrenEntitiesAction.APPEND:
808808
# get previous entity list rows
809-
last_entities = last_version.entity_list.entitylistrow_set.only("entity_id", "entity_version_id")
809+
last_entities = last_version.entity_list.entitylistrow_set.only(
810+
"entity_id",
811+
"entity_version_id"
812+
).order_by("order_num")
810813
# append given publishable_entities_pks and entity_version_pks
811814
publishable_entities_pks = [entity.entity_id for entity in last_entities] + publishable_entities_pks
812815
entity_version_pks = [ # type: ignore[operator, assignment]
@@ -815,7 +818,10 @@ def create_next_entity_list(
815818
] + entity_version_pks
816819
elif entities_action == ChildrenEntitiesAction.REMOVE:
817820
# get previous entity list rows
818-
last_entities = last_version.entity_list.entitylistrow_set.only("entity_id", "entity_version_id")
821+
last_entities = last_version.entity_list.entitylistrow_set.only(
822+
"entity_id",
823+
"entity_version_id"
824+
).order_by("order_num")
819825
# Remove entities that are in publishable_entities_pks
820826
new_entities = [
821827
entity

0 commit comments

Comments
 (0)