refactor!: use LibraryCollectionLocator in LibraryCollectionData

The library_key can be inferred from the collection_key

Author: pomegranited

openedx_events/content_authoring/data.py

@@ -12,7 +12,7 @@
 
 import attr
 from opaque_keys.edx.keys import CourseKey, UsageKey
-from opaque_keys.edx.locator import LibraryLocatorV2, LibraryUsageLocatorV2
+from opaque_keys.edx.locator import LibraryCollectionLocator, LibraryLocatorV2, LibraryUsageLocatorV2
 
 
 @attr.s(frozen=True)
@@ -218,14 +218,12 @@ class LibraryCollectionData:
     Data related to a library collection that has changed.
 
     Attributes:
-        library_key (LibraryLocatorV2): a key that represents a content library.
-        collection_key (str): identifies the collection within the library's learning package
+        collection_key (LibraryCollectionLocator): identifies the collection within the library's learning package
         background (bool): indicate whether the sender doesn't want to wait for handler to finish execution,
            i.e., the handler can run the task in background. By default it is False.
     """
 
-    library_key = attr.ib(type=LibraryLocatorV2)
-    collection_key = attr.ib(type=str)
+    collection_key = attr.ib(type=LibraryCollectionLocator)
     background = attr.ib(type=bool, default=False)
 
 

openedx_events/event_bus/avro/custom_serializers.py

@@ -8,7 +8,7 @@
 
 from ccx_keys.locator import CCXLocator
 from opaque_keys.edx.keys import CourseKey, UsageKey
-from opaque_keys.edx.locator import LibraryLocatorV2, LibraryUsageLocatorV2
+from opaque_keys.edx.locator import LibraryCollectionLocator, LibraryLocatorV2, LibraryUsageLocatorV2
 
 from openedx_events.event_bus.avro.types import PYTHON_TYPE_TO_AVRO_MAPPING
 
@@ -112,6 +112,25 @@ def deserialize(data: str):
         return UsageKey.from_string(data)
 
 
+class LibraryCollectionLocatorAvroSerializer(BaseCustomTypeAvroSerializer):
+    """
+    CustomTypeAvroSerializer for LibraryCollectionLocator class.
+    """
+
+    cls = LibraryCollectionLocator
+    field_type = PYTHON_TYPE_TO_AVRO_MAPPING[str]
+
+    @staticmethod
+    def serialize(obj) -> str:
+        """Serialize obj into string."""
+        return str(obj)
+
+    @staticmethod
+    def deserialize(data: str):
+        """Deserialize string into obj."""
+        return LibraryCollectionLocator.from_string(data)
+
+
 class LibraryLocatorV2AvroSerializer(BaseCustomTypeAvroSerializer):
     """
     CustomTypeAvroSerializer for LibraryLocatorV2 class.
@@ -175,6 +194,7 @@ def deserialize(data: str):
     CourseKeyAvroSerializer,
     CcxCourseLocatorAvroSerializer,
     DatetimeAvroSerializer,
+    LibraryCollectionLocatorAvroSerializer,
     LibraryLocatorV2AvroSerializer,
     LibraryUsageLocatorV2AvroSerializer,
     UsageKeyAvroSerializer,

openedx_events/event_bus/avro/tests/schemas/org+openedx+content_authoring+content_library+collection+created+v1_schema.avsc

@@ -9,10 +9,6 @@
         "name": "LibraryCollectionData",
         "type": "record",
         "fields": [
-          {
-            "name": "library_key",
-            "type": "string"
-          },
           {
             "name": "collection_key",
             "type": "string"

openedx_events/event_bus/avro/tests/schemas/org+openedx+content_authoring+content_library+collection+deleted+v1_schema.avsc

@@ -9,10 +9,6 @@
         "name": "LibraryCollectionData",
         "type": "record",
         "fields": [
-          {
-            "name": "library_key",
-            "type": "string"
-          },
           {
             "name": "collection_key",
             "type": "string"

openedx_events/event_bus/avro/tests/schemas/org+openedx+content_authoring+content_library+collection+updated+v1_schema.avsc

@@ -9,10 +9,6 @@
         "name": "LibraryCollectionData",
         "type": "record",
         "fields": [
-          {
-            "name": "library_key",
-            "type": "string"
-          },
           {
             "name": "collection_key",
             "type": "string"

openedx_events/event_bus/avro/tests/test_avro.py

@@ -11,7 +11,7 @@
 from fastavro.repository.base import SchemaRepositoryError
 from fastavro.schema import load_schema
 from opaque_keys.edx.keys import CourseKey, UsageKey
-from opaque_keys.edx.locator import LibraryLocatorV2, LibraryUsageLocatorV2
+from opaque_keys.edx.locator import LibraryCollectionLocator, LibraryLocatorV2, LibraryUsageLocatorV2
 
 from openedx_events.event_bus.avro.deserializer import AvroSignalDeserializer, deserialize_bytes_to_event_data
 from openedx_events.event_bus.avro.serializer import AvroSignalSerializer, serialize_event_data_to_bytes
@@ -109,6 +109,7 @@ def generate_test_event_data_for_data_type(data_type):  # pragma: no cover
         UsageKey: UsageKey.from_string(
             "block-v1:edx+DemoX+Demo_course+type@video+block@UaEBjyMjcLW65gaTXggB93WmvoxGAJa0JeHRrDThk",
         ),
+        LibraryCollectionLocator: LibraryCollectionLocator.from_string('lib-collection:MITx:reallyhardproblems:col1'),
         LibraryLocatorV2: LibraryLocatorV2.from_string('lib:MITx:reallyhardproblems'),
         LibraryUsageLocatorV2: LibraryUsageLocatorV2.from_string('lb:MITx:reallyhardproblems:problem:problem1'),
         List[int]: [1, 2, 3],
@@ -125,6 +126,9 @@ def generate_test_event_data_for_data_type(data_type):  # pragma: no cover
             "block-v1:edx+DemoX+Demo_course+type@video+block@UaEBjyMjcLW65gaTXggB93WmvoxGAJa0JeHRrDThk",
         )},
         dict[str, LibraryLocatorV2]: {'key': LibraryLocatorV2.from_string('lib:MITx:reallyhardproblems')},
+        dict[str, LibraryCollectionLocator]: {
+            'key': LibraryCollectionLocator.from_string('lib-collection:MITx:reallyhardproblems:col1'),
+        },
         dict[str, LibraryUsageLocatorV2]: {
             'key': LibraryUsageLocatorV2.from_string('lb:MITx:reallyhardproblems:problem:problem1'),
         },