Skip to content

chore: update team_reviewers to match latest team conventions#353

Open
mariajgrimaldi wants to merge 1 commit intomainfrom
MJG/update-team-reviewers
Open

chore: update team_reviewers to match latest team conventions#353
mariajgrimaldi wants to merge 1 commit intomainfrom
MJG/update-team-reviewers

Conversation

@mariajgrimaldi
Copy link
Copy Markdown
Member

Description

The "Upgrade Python Requirements" workflow was partially failing because of the step "create pull request" which couldn't tag team reviewers that pointed to an out of date team: https://github.com/openedx/openedx-events/actions/runs/24643061070/job/72050417661

Supporting information

https://openedx.atlassian.net/wiki/spaces/COMM/pages/3555852316/GitHub+Access+Team+Structure

Testing instructions

You can see a successfull run here: https://github.com/openedx/openedx-events/actions/runs/24664886728/job/72119882641

Checklists

Check off if complete or not applicable:

Merge Checklist:

  • All reviewers approved
  • Reviewer tested the code following the testing instructions
  • CI build is green
  • Version bumped NA
  • Changelog record added with short description of the change and current date NA
  • Documentation updated (not only docstrings) NA
  • Integration with other services reviewed NA
  • Fixup commits are squashed away NA
  • Unit tests added/updated NA
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets NA

Post Merge:

  • Create a tag
  • Create a release on GitHub
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)
  • Upgrade the package in the Open edX platform requirements (if applicable)

The "Upgrade Python Requirements" workflow was partially failing because
of the step "create pull request" which couldn't tag team reviewers
that pointed to an out of date team.
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Apr 20, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @mariajgrimaldi!

This repository is currently maintained by @openedx/committers-openedx-filters.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Apr 20, 2026
@mariajgrimaldi mariajgrimaldi requested a review from a team April 21, 2026 09:33
Copy link
Copy Markdown
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @mariajgrimaldi

Copy link
Copy Markdown
Contributor

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: In Eng Review

Development

Successfully merging this pull request may close these issues.

5 participants