You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/copilot-instructions.md
+40Lines changed: 40 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -10,3 +10,43 @@ At the start of every session, before doing any other work, read:
10
10
11
11
Treat their contents as binding project instructions for the remainder of the
12
12
session, equivalent to instructions in this file.
13
+
14
+
## PR Review Instructions
15
+
16
+
When reviewing a PR, focus on the areas below.
17
+
18
+
### Code correctness and performance
19
+
20
+
1. Flag incorrect business logic.
21
+
2. Flag areas that are potentially inefficient or unperformant.
22
+
23
+
### Excess and redundancy
24
+
25
+
Bias toward flagging **excess and redundancy**.
26
+
27
+
1.**Reuse before reinvent.** Flag code that duplicates existing functionality - identify the existing equivalent symbol.
28
+
2.**Earn every guard.** Defensive code (try/except, null-checks, fallbacks) must address a
29
+
failure that can actually happen at this call site given the system's invariants.
30
+
3.**Don't swallow exceptions.** If you catch an exception, re-raise it or convert it to a more actionable error; avoid catch-and-log-only (or catch-and-ignore) handling.
31
+
4.**YAGNI / trust the defaults.** Don't build for hypothetical futures. Don't re-implement what
32
+
the framework already does (DRF pagination, auth, serializer defaults). Flag speculative
33
+
generality and needless overrides of correct defaults.
34
+
5.**Respect the source of truth.** Data should be read from its canonical owner. Flag calls to
35
+
external services for data the system already stores locally (e.g. a live Stripe price lookup
36
+
when a local price table keyed by slug exists). Name the local source you're pointing to.
0 commit comments