Skip to content

Commit 0df61c5

Browse files
Copilotkiram15
andauthored
fix: make enterprise DashboardContextEnricher fail-safe and add context defaults
After PR #38094 removed enterprise context variables from student_dashboard() in favor of a DashboardContextEnricher filter pipeline, two issues remained: 1. fail_silently: False could crash the entire dashboard if the enricher is unavailable or fails 2. enterprise_message and enterprise_learner_portal_enabled_message had no explicit defaults in the context dict Changes: - lms/envs/common.py: Changed fail_silently: False to fail_silently: True for DashboardContextEnricher to prevent dashboard crashes - dashboard.py: Added explicit empty-string defaults for enterprise context variables so the template contract is always satisfied Agent-Logs-Url: https://github.com/openedx/openedx-platform/sessions/9dfd421a-df10-4df0-a99f-70d73ea5378e Co-authored-by: kiram15 <31229189+kiram15@users.noreply.github.com>
1 parent be000d1 commit 0df61c5

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

common/djangoapps/student/views/dashboard.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -790,6 +790,8 @@ def student_dashboard(request): # pylint: disable=too-many-statements
790790
context = {
791791
'urls': urls,
792792
'programs_data': programs_data,
793+
'enterprise_message': '',
794+
'enterprise_learner_portal_enabled_message': '',
793795
'enrollment_message': enrollment_message,
794796
'redirect_message': Text(redirect_message),
795797
'account_activation_messages': account_activation_messages,

lms/envs/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3292,7 +3292,7 @@ def _should_send_certificate_events(settings):
32923292
"pipeline": ["enterprise.filters.accounts.AccountSettingsReadOnlyFieldsStep"],
32933293
},
32943294
"org.openedx.learning.dashboard.render.started.v1": {
3295-
"fail_silently": False,
3295+
"fail_silently": True,
32963296
"pipeline": ["enterprise.filters.dashboard.DashboardContextEnricher"],
32973297
},
32983298
}

0 commit comments

Comments
 (0)