fixup! fix: adjust studio_grading_url to use the correct URL

Author: dwong2708

lms/djangoapps/instructor/tests/test_api_v2.py

@@ -180,6 +180,19 @@ def test_get_course_metadata_as_instructor(self):
         assert data['studio_grading_url'] == f'http://localhost:2001/authoring/course/{self.course.id}/settings/grading'
         assert data['admin_console_url'] == 'http://localhost:2025/admin-console/authz'
 
+    def test_admin_console_url_requires_instructor_access(self):
+        """
+        Test that the admin console URL is only available to users with instructor access.
+        """
+        # data researcher has access to course but is not an instructor
+        self.client.force_authenticate(user=self.data_researcher)
+        response = self.client.get(self._get_url())
+
+        assert response.status_code == status.HTTP_200_OK
+        assert 'admin_console_url' in response.data
+        data = response.data
+        assert data['admin_console_url'] is None
+
     def test_get_course_metadata_as_staff(self):
         """
         Test that course staff can retrieve course metadata.

lms/djangoapps/instructor/views/serializers_v2.py

@@ -76,7 +76,7 @@ class CourseInformationSerializerV2(serializers.Serializer):
         help_text="URL to the Studio grading settings page for the course (null if not configured)"
     )
     admin_console_url = serializers.SerializerMethodField(
-        help_text="URL to the admin console"
+        help_text="URL to the admin console (requires instructor access and MFE configuration, null if not accessible)"
     )
     permissions = serializers.SerializerMethodField(help_text="User permissions for instructor dashboard features")
     tabs = serializers.SerializerMethodField(help_text="List of course tabs with configuration and display information")
@@ -469,7 +469,7 @@ def get_studio_grading_url(self, data):
         return f'{mfe_base_url}/course/{course_key}/settings/grading'
 
     def get_admin_console_url(self, data):
-        """Get admin console URL."""
+        """Get admin console URL (requires instructor access and MFE configuration, null if not accessible)."""
         course_key = data['course'].id
         request = data['request']
         has_instructor_access = has_access(request.user, 'instructor', data['course'])
@@ -480,7 +480,6 @@ def get_admin_console_url(self, data):
         )
         if not mfe_base_url or not has_instructor_access:
             return None
-
         return f'{mfe_base_url}/authz'
 
     def get_disable_buttons(self, data):