Skip to content

Commit 22f0eb2

Browse files
authored
Merge branch 'master' into pwnage101/ENT-11563
2 parents 2ad7aa1 + a18e9d1 commit 22f0eb2

4 files changed

Lines changed: 67 additions & 135 deletions

File tree

lms/djangoapps/grades/tests/test_events.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ def test_filter_called_with_context(self, mock_run_filter):
254254
and merge the returned context.
255255
"""
256256
enriched = {"org": "test_org", "enterprise_uuid": "abc-123"}
257-
mock_run_filter.return_value = enriched
257+
mock_run_filter.return_value = (enriched, self.user.id, self.course.id)
258258

259259
from lms.djangoapps.grades.events import course_grade_passed_first_time
260260
with patch('lms.djangoapps.grades.events.tracker'):
@@ -270,7 +270,7 @@ def test_filter_none_return_leaves_context_intact(self, mock_run_filter):
270270
"""
271271
If run_filter returns None (fail_silently path), context is not overwritten.
272272
"""
273-
mock_run_filter.return_value = None
273+
mock_run_filter.return_value = (None, self.user.id, self.course.id)
274274
from lms.djangoapps.grades.events import course_grade_passed_first_time
275275
with patch('lms.djangoapps.grades.events.tracker'):
276276
# Should not raise even when filter returns None

lms/envs/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3293,7 +3293,7 @@ def _should_send_certificate_events(settings):
32933293
"fail_silently": False,
32943294
"pipeline": ["enterprise.filters.accounts.AccountSettingsReadOnlyFieldsStep"],
32953295
},
3296-
"org.openedx.learning.dashboard.render.started.v1": {
3296+
"org.openedx.learning.grade.context.requested.v1": {
32973297
"fail_silently": False,
32983298
"pipeline": ["enterprise.filters.dashboard.DashboardContextEnricher"],
32993299
},

package-lock.json

Lines changed: 63 additions & 131 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
"@testing-library/jest-dom": "^6",
4848
"@testing-library/react": "^12",
4949
"@testing-library/user-event": "^12",
50-
"babel-loader": "^9",
50+
"babel-loader": "^10.0.0",
5151
"babel-plugin-transform-class-properties": "^6",
5252
"babel-polyfill": "^6",
5353
"backbone": "^1",

0 commit comments

Comments
 (0)