Skip to content

Commit 24f3732

Browse files
authored
Merge branch 'master' into fix/use-masqueraded-user-for-course-outline
2 parents 65e987c + d83c598 commit 24f3732

3 files changed

Lines changed: 20 additions & 5 deletions

File tree

cms/djangoapps/contentstore/rest_api/v2/serializers/home.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@ class CourseCommonSerializerV2(serializers.Serializer):
3030
lms_link = serializers.SerializerMethodField()
3131
cms_link = serializers.SerializerMethodField()
3232
number = serializers.CharField()
33+
display_number = serializers.CharField(source='display_number_with_default')
3334
org = serializers.CharField()
35+
display_org = serializers.CharField(source='display_org_with_default')
3436
rerun_link = serializers.SerializerMethodField()
3537
run = serializers.CharField(source='id.run')
3638
url = serializers.SerializerMethodField()

cms/djangoapps/contentstore/rest_api/v2/views/tests/test_home.py

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,10 @@ def test_home_page_response(self):
5656
("display_name", self.course.display_name),
5757
("lms_link", f'{settings.LMS_ROOT_URL}/courses/{course_id}/jump_to/{self.course.location}'),
5858
("cms_link", f'//{settings.CMS_BASE}{reverse_course_url("course_handler", self.course.id)}'),
59-
("number", self.course.number),
60-
("org", self.course.org),
59+
("number", self.active_course.number),
60+
("display_number", self.active_course.display_number_with_default),
61+
("org", self.active_course.org),
62+
("display_org", self.active_course.display_org_with_default),
6163
("rerun_link", f'/course_rerun/{course_id}'),
6264
("run", self.course.id.run),
6365
("url", f'/course/{course_id}'),
@@ -75,7 +77,9 @@ def test_home_page_response(self):
7577
f'//{settings.CMS_BASE}{reverse_course_url("course_handler", self.archived_course.id)}',
7678
),
7779
("number", self.archived_course.number),
80+
("display_number", self.archived_course.display_number_with_default),
7881
("org", self.archived_course.org),
82+
("display_org", self.archived_course.display_org_with_default),
7983
("rerun_link", f'/course_rerun/{str(self.archived_course.id)}'),
8084
("run", self.archived_course.id.run),
8185
("url", f'/course/{str(self.archived_course.id)}'),
@@ -109,8 +113,10 @@ def test_active_only_query_if_passed(self):
109113
("display_name", self.course.display_name),
110114
("lms_link", f'{settings.LMS_ROOT_URL}/courses/{str(self.course.id)}/jump_to/{self.course.location}'),
111115
("cms_link", f'//{settings.CMS_BASE}{reverse_course_url("course_handler", self.course.id)}'),
112-
("number", self.course.number),
113-
("org", self.course.org),
116+
("number", self.active_course.number),
117+
("display_number", self.active_course.display_number_with_default),
118+
("org", self.active_course.org),
119+
("display_org", self.active_course.display_org_with_default),
114120
("rerun_link", f'/course_rerun/{str(self.course.id)}'),
115121
("run", self.course.id.run),
116122
("url", f'/course/{str(self.course.id)}'),
@@ -140,7 +146,9 @@ def test_archived_only_query_if_passed(self):
140146
),
141147
("cms_link", f'//{settings.CMS_BASE}{reverse_course_url("course_handler", self.archived_course.id)}'),
142148
("number", self.archived_course.number),
149+
("display_number", self.archived_course.display_number_with_default),
143150
("org", self.archived_course.org),
151+
("display_org", self.archived_course.display_org_with_default),
144152
("rerun_link", f'/course_rerun/{str(self.archived_course.id)}'),
145153
("run", self.archived_course.id.run),
146154
("url", f'/course/{str(self.archived_course.id)}'),
@@ -170,7 +178,9 @@ def test_search_query_if_passed(self):
170178
),
171179
("cms_link", f'//{settings.CMS_BASE}{reverse_course_url("course_handler", self.archived_course.id)}'),
172180
("number", self.archived_course.number),
181+
("display_number", self.archived_course.display_number_with_default),
173182
("org", self.archived_course.org),
183+
("display_org", self.archived_course.display_org_with_default),
174184
("rerun_link", f'/course_rerun/{str(self.archived_course.id)}'),
175185
("run", self.archived_course.id.run),
176186
("url", f'/course/{str(self.archived_course.id)}'),

cms/static/sass/elements/_modal-window.scss

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,13 +409,16 @@
409409
div.edit-xblock-modal {
410410
display: flex;
411411
flex-direction: column;
412+
min-height: 0;
412413
flex-grow: 1;
413414

414415
div.modal-content {
415416
display: flex;
416417
flex-direction: column;
417-
flex-grow: 1;
418+
flex: 1;
419+
min-height: 0;
418420
padding: 0;
421+
overflow: auto;
419422

420423
div.xblock-editor {
421424
display: flex;

0 commit comments

Comments
 (0)