refactor: assign media at time of component version creation

Author: ormsbee

openedx/core/djangoapps/content_libraries/api/blocks.py

@@ -193,7 +193,11 @@ def get_library_block(usage_key: LibraryUsageLocatorV2, include_collections=Fals
     return xblock_metadata
 
 
-def set_library_block_olx(usage_key: LibraryUsageLocatorV2, new_olx_str: str) -> ComponentVersion:
+def set_library_block_olx(
+    usage_key: LibraryUsageLocatorV2,
+    new_olx_str: str,
+    paths_to_media: dict = None,
+) -> ComponentVersion:
     """
     Replace the OLX source of the given XBlock.
 
@@ -204,6 +208,7 @@ def set_library_block_olx(usage_key: LibraryUsageLocatorV2, new_olx_str: str) ->
     Returns the version number of the newly created ComponentVersion.
     """
     assert isinstance(usage_key, LibraryUsageLocatorV2)
+    paths_to_media = paths_to_media or {}
 
     # HTMLBlock uses CDATA to preserve HTML inside the XML, so make sure we
     # don't strip that out.
@@ -240,7 +245,7 @@ def set_library_block_olx(usage_key: LibraryUsageLocatorV2, new_olx_str: str) ->
     now = datetime.now(tz=timezone.utc)  # noqa: UP017
 
     with transaction.atomic():
-        new_content = content_api.get_or_create_text_media(
+        new_olx_media = content_api.get_or_create_text_media(
             component.learning_package_id,
             get_or_create_olx_media_type(usage_key.block_type).id,
             text=new_olx_str,
@@ -250,7 +255,8 @@ def set_library_block_olx(usage_key: LibraryUsageLocatorV2, new_olx_str: str) ->
             component.id,
             title=new_title,
             media_to_replace={
-                'block.xml': new_content.pk,
+                **paths_to_media,
+                'block.xml': new_olx_media.pk,
             },
             created=now,
         )
@@ -433,11 +439,7 @@ def _import_staged_block(
             created_by=user.id,
         )
 
-        # This will create the first component version and set the OLX/title
-        # appropriately. It will not publish. Once we get the newly created
-        # ComponentVersion back from this, we can attach all our files to it.
-        component_version = set_library_block_olx(usage_key, olx_str)
-
+        paths_to_media = {}
         for staged_content_file_data in staged_content_files:
             # The ``data`` attribute is going to be None because the clipboard
             # is optimized to not do redundant file copying when copying/pasting
@@ -484,17 +486,18 @@ def _import_staged_block(
                 media_type_str = "application/octet-stream"
 
             media_type = content_api.get_or_create_media_type(media_type_str)
-            content = content_api.get_or_create_file_media(
+            media = content_api.get_or_create_file_media(
                 learning_package.id,
                 media_type.id,
                 data=file_data,
                 created=now,
             )
-            content_api.create_component_version_media(
-                component_version.pk,
-                content.id,
-                path=filename,
-            )
+            paths_to_media[filename] = media.id
+
+        # This will create the first component version and set the OLX/title
+        # appropriately. It will not publish. Once we get the newly created
+        # ComponentVersion back from this, we can attach all our files to it.
+        set_library_block_olx(usage_key, olx_str, paths_to_media)
 
     # Emit library block created event
     # .. event_implemented_name: LIBRARY_BLOCK_CREATED
@@ -1046,25 +1049,23 @@ def _create_component_for_block(
         component_type = content_api.get_or_create_component_type(
             "xblock.v1", usage_key.block_type
         )
-        component, component_version = content_api.create_component_and_version(
+        block_olx_media = content_api.get_or_create_text_media(
+            learning_package.id,
+            get_or_create_olx_media_type(usage_key.block_type).id,
+            text=xml_text,
+            created=now,
+        )
+        _component, component_version = content_api.create_component_and_version(
             learning_package.id,
             component_type=component_type,
             component_code=usage_key.block_id,
             title=display_name,
             created=now,
             created_by=user_id,
             can_stand_alone=can_stand_alone,
-        )
-        content = content_api.get_or_create_text_media(
-            learning_package.id,
-            get_or_create_olx_media_type(usage_key.block_type).id,
-            text=xml_text,
-            created=now,
-        )
-        content_api.create_component_version_media(
-            component_version.pk,
-            content.id,
-            path="block.xml",
+            media={
+                'block.xml': block_olx_media
+            }
         )
 
         return component_version