Skip to content

Commit 66bc303

Browse files
authored
Merge branch 'master' into pwnage101/ENT-11569
2 parents 76176bf + 14dcc1f commit 66bc303

3 files changed

Lines changed: 11 additions & 5 deletions

File tree

.github/workflows/unit-tests.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ on:
88
push:
99
branches:
1010
- master
11+
- release/*
1112

1213
concurrency:
1314
# We only need to be running tests for the latest commit on each PR

lms/djangoapps/mfe_config_api/tests/test_views.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -457,13 +457,16 @@ def side_effect(key, default=None):
457457
response = self.client.get(self.url)
458458
data = response.json()
459459

460-
# Site-level key translated to top level
460+
common = data["commonAppConfig"]
461+
# Site-level keys are translated to top level
461462
self.assertEqual(data["lmsBaseUrl"], "https://courses.example.com") # noqa: PT009
463+
self.assertEqual(data["cmsBaseUrl"], "https://studio.example.com") # noqa: PT009
464+
# Site-level keys translated to top level don't appear in commonAppConfig
465+
self.assertNotIn("LMS_BASE_URL", common) # noqa: PT009
466+
self.assertNotIn("STUDIO_BASE_URL", common) # noqa: PT009
462467
# Unmapped MFE_CONFIG keys appear in commonAppConfig (not at the top level)
463468
self.assertNotIn("CREDENTIALS_BASE_URL", data) # noqa: PT009
464-
common = data["commonAppConfig"]
465469
self.assertEqual(common["CREDENTIALS_BASE_URL"], "https://credentials.example.com") # noqa: PT009
466-
self.assertEqual(common["STUDIO_BASE_URL"], "https://studio.example.com") # noqa: PT009
467470
# Legacy config keys also appear in commonAppConfig
468471
for legacy_key in default_legacy_config:
469472
self.assertIn(legacy_key, common) # noqa: PT009
@@ -609,12 +612,13 @@ def side_effect(key, default=None):
609612
response = self.client.get(self.url)
610613
data = response.json()
611614

612-
# Site-level key is promoted to the top level
615+
# Site-level keys are promoted to the top level
613616
self.assertEqual(data["lmsBaseUrl"], "https://courses.example.com") # noqa: PT009
617+
self.assertEqual(data["cmsBaseUrl"], "https://studio.example.com") # noqa: PT009
614618
# Unmapped keys are preserved in commonAppConfig
615619
common = data["commonAppConfig"]
616620
self.assertEqual(common["CREDENTIALS_BASE_URL"], "https://credentials.example.com") # noqa: PT009
617-
self.assertEqual(common["STUDIO_BASE_URL"], "https://studio.example.com") # noqa: PT009
621+
self.assertNotIn("STUDIO_BASE_URL", common) # noqa: PT009
618622

619623
@patch("lms.djangoapps.mfe_config_api.views.get_legacy_config_overrides", return_value={})
620624
@patch("lms.djangoapps.mfe_config_api.views.configuration_helpers")

lms/djangoapps/mfe_config_api/views.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
"LOGIN_URL": "loginUrl",
3131
"LOGOUT_URL": "logoutUrl",
3232
# OptionalSiteConfig
33+
"STUDIO_BASE_URL": "cmsBaseUrl",
3334
"LOGO_URL": "headerLogoImageUrl",
3435
"ACCESS_TOKEN_COOKIE_NAME": "accessTokenCookieName",
3536
"LANGUAGE_PREFERENCE_COOKIE_NAME": "languagePreferenceCookieName",

0 commit comments

Comments
 (0)