refactor: migrate ENABLE_PASSWORD_RESET_FAILURE_EMAIL off FEATURES-as-dict

Default flips from raising KeyError (`settings.FEATURES['…']` direct
subscript, only safe inside an active patch) to False (`getattr` with
default) — the flag isn't defined in any env file.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: feanil

openedx/core/djangoapps/user_authn/views/password_reset.py

@@ -642,7 +642,7 @@ def password_change_request_handler(request):
             # If enabled, send an email saying that a password reset was attempted, but that there is
             # no user associated with the email
             if configuration_helpers.get_value('ENABLE_PASSWORD_RESET_FAILURE_EMAIL',
-                                               settings.FEATURES['ENABLE_PASSWORD_RESET_FAILURE_EMAIL']):
+                                               settings.ENABLE_PASSWORD_RESET_FAILURE_EMAIL):
                 site = get_current_site()
                 message_context = get_base_template_context(site)
 

openedx/core/djangoapps/user_authn/views/tests/test_password.py

@@ -14,7 +14,7 @@
 from django.contrib.auth import get_user_model
 from django.core import mail
 from django.core.cache import cache
-from django.test import TestCase
+from django.test import TestCase, override_settings
 from django.test.client import RequestFactory
 from django.urls import reverse
 from freezegun import freeze_time
@@ -215,7 +215,7 @@ def test_password_change_failure(self):
             self._change_password()
             self.assertRaises(UserAPIInternalError)  # noqa: PT027
 
-    @patch.dict(settings.FEATURES, {'ENABLE_PASSWORD_RESET_FAILURE_EMAIL': True})
+    @override_settings(ENABLE_PASSWORD_RESET_FAILURE_EMAIL=True)
     def test_password_reset_failure_email(self):
         """Test that a password reset failure email notification is sent, when enabled."""
         # Log the user out