Skip to content

Commit 9e0fcc8

Browse files
feanilclaude
andcommitted
feat: remove ENABLE_MKTG_SITE guards from navbar templates
Marketing navigation links (HOW_IT_WORKS, COURSES, SCHOOLS) are now always rendered in the unauthenticated nav bars. marketing_link() falls back to '#' when a URL is not configured in MKTG_URLS. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent ba02ae2 commit 9e0fcc8

2 files changed

Lines changed: 9 additions & 14 deletions

File tree

lms/templates/header/navbar-not-authenticated.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
%>
1515

1616
<%
17-
mktg_site_enabled = static.get_value('ENABLE_MKTG_SITE', settings.FEATURES.get('ENABLE_MKTG_SITE', False))
1817
courses_are_browsable = settings.FEATURES.get('COURSES_ARE_BROWSABLE')
1918
allows_login = not settings.FEATURES['DISABLE_LOGIN_BUTTON'] and not combined_login_and_register
2019
can_discover_courses = settings.FEATURES.get('ENABLE_COURSE_DISCOVERY')
@@ -23,7 +22,6 @@
2322
%>
2423
<nav class="nav-links" aria-label=${_("Supplemental Links")}>
2524
<div class="main">
26-
% if mktg_site_enabled:
2725
<div class="mobile-nav-item hidden-mobile nav-item">
2826
<a href="${marketing_link('HOW_IT_WORKS')}">${_("How it Works")}</a>
2927
</div>
@@ -35,7 +33,6 @@
3533
<div class="mobile-nav-item hidden-mobile nav-item">
3634
<a href="${marketing_link('SCHOOLS')}">${_("Schools")}</a>
3735
</div>
38-
% endif
3936
% if allows_login:
4037
% if can_discover_courses:
4138
<div class="mobile-nav-item hidden-mobile nav-item">

lms/templates/navigation/navbar-not-authenticated.html

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,17 @@
1111

1212
<ol class="left list-inline nav-global">
1313
<%block name="navigation_global_links">
14-
% if static.get_value('ENABLE_MKTG_SITE', settings.FEATURES.get('ENABLE_MKTG_SITE', False)):
15-
<li class="item nav-global-01">
16-
<a class="btn" href="${marketing_link('HOW_IT_WORKS')}">${_("How it Works")}</a>
17-
</li>
18-
% if settings.FEATURES.get('COURSES_ARE_BROWSABLE'):
19-
<li class="item nav-global-02">
20-
<a class="btn" href="${marketing_link('COURSES')}">${_("Courses")}</a>
21-
</li>
22-
% endif
23-
<li class="item nav-global-03">
24-
<a class="btn" href="${marketing_link('SCHOOLS')}">${_("Schools")}</a>
14+
<li class="item nav-global-01">
15+
<a class="btn" href="${marketing_link('HOW_IT_WORKS')}">${_("How it Works")}</a>
16+
</li>
17+
% if settings.FEATURES.get('COURSES_ARE_BROWSABLE'):
18+
<li class="item nav-global-02">
19+
<a class="btn" href="${marketing_link('COURSES')}">${_("Courses")}</a>
2520
</li>
2621
% endif
22+
<li class="item nav-global-03">
23+
<a class="btn" href="${marketing_link('SCHOOLS')}">${_("Schools")}</a>
24+
</li>
2725
</%block>
2826

2927
<%block name="navigation_other_global_links">

0 commit comments

Comments
 (0)