feat: remove ENABLE_MKTG_SITE from CMS, registration tests, and docs

feanil · claude · feanil · commit ba02ae27b560 · 2026-07-16T09:05:53.000-04:00
- contentstore utils: marketing_enabled is always True
- registration tests: remove ENABLE_MKTG_SITE=False test cases that
  tested now-dead local URL generation for honor code and TOS links;
  remove ENABLE_MKTG_SITE=True decorators from the remaining tests
- site_configuration test mixin: remove ENABLE_MKTG_SITE example key
- schedules README: remove ENABLE_MKTG_SITE from example config

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/cms/djangoapps/contentstore/rest_api/v1/views/tests/test_settings.py b/cms/djangoapps/contentstore/rest_api/v1/views/tests/test_settings.py
@@ -47,7 +47,7 @@ def test_course_settings_response(self):
             "is_prerequisite_courses_enabled": False,
             "language_options": settings.ALL_LANGUAGES,
             "lms_link_for_about_page": get_link_for_about_page(self.course),
-            "marketing_enabled": False,
+            "marketing_enabled": True,
             "mfe_proctored_exam_settings_url": get_proctored_exam_settings_url(
                 self.course.id
             ),
diff --git a/cms/djangoapps/contentstore/utils.py b/cms/djangoapps/contentstore/utils.py
@@ -1387,11 +1387,7 @@ def get_course_settings(request, course_key, course_block):
         'ENABLE_PUBLISHER',
         settings.FEATURES.get('ENABLE_PUBLISHER', False)
     )
-    marketing_enabled = configuration_helpers.get_value_for_org(
-        course_block.location.org,
-        'ENABLE_MKTG_SITE',
-        settings.FEATURES.get('ENABLE_MKTG_SITE', False)
-    )
+    marketing_enabled = True
     enable_extended_course_details = configuration_helpers.get_value_for_org(
         course_block.location.org,
         'ENABLE_EXTENDED_COURSE_DETAILS',
diff --git a/openedx/core/djangoapps/schedules/docs/README.rst b/openedx/core/djangoapps/schedules/docs/README.rst
@@ -208,9 +208,6 @@ add/change the following:
 
 .. code:: python
 
-    FEATURES = {
-        'ENABLE_MKTG_SITE': True,
-    }
     MKTG_URLS = {
         'ROOT': '<insert_lms_url_here>',
     }
diff --git a/openedx/core/djangoapps/site_configuration/tests/mixins.py b/openedx/core/djangoapps/site_configuration/tests/mixins.py
@@ -33,7 +33,6 @@ def setUp(self):
             "SITE_NAME": self.site_other.domain,
             "SESSION_COOKIE_DOMAIN": self.site_other.domain,
             "course_org_filter": "fakeOtherX",
-            "ENABLE_MKTG_SITE": True,
             "SHOW_ECOMMERCE_REPORTS": True,
             "MKTG_URLS": {
                 "ROOT": "https://marketing.fakeother",
diff --git a/openedx/core/djangoapps/user_authn/views/tests/test_register.py b/openedx/core/djangoapps/user_authn/views/tests/test_register.py
@@ -1127,7 +1127,6 @@ def test_registration_form_confirm_email(self):
     @override_settings(
         MKTG_URLS={"ROOT": "https://www.test.com/", "HONOR": "honor"},
     )
-    @mock.patch.dict(settings.FEATURES, {"ENABLE_MKTG_SITE": True})
     def test_registration_honor_code_mktg_site_enabled(self):
         link_template = "<a href='https://www.test.com/honor' rel='noopener' target='_blank'>{link_label}</a>"
         link_template2 = "<a href='#' rel='noopener' target='_blank'>{link_label}</a>"
@@ -1159,44 +1158,11 @@ def test_registration_honor_code_mktg_site_enabled(self):
             }
         )
 
-    @override_settings(MKTG_URLS_LINK_MAP={"HONOR": "honor"})
-    @mock.patch.dict(settings.FEATURES, {"ENABLE_MKTG_SITE": False})
-    def test_registration_honor_code_mktg_site_disabled(self):
-        link_template = "<a href='/privacy' rel='noopener' target='_blank'>{link_label}</a>"
-        link_label = "Terms of Service and Honor Code"
-        link_label2 = "Privacy Policy"
-        self._assert_reg_field(
-            {"honor_code": "required"},
-            {
-                "label": ("By creating an account, you agree to the {spacing}"
-                          "{link_label} {spacing}"
-                          "and you acknowledge that {platform_name} and each Member process your "
-                          "personal data in accordance {spacing}"
-                          "with the {link_label2}.").format(
-                    platform_name=settings.PLATFORM_NAME,
-                    link_label=self.link_template.format(link_label=link_label),
-                    link_label2=link_template.format(link_label=link_label2),
-                    spacing=' ' * 18
-                ),
-                "name": "honor_code",
-                "defaultValue": False,
-                "type": "plaintext",
-                "required": True,
-                "errorMessages": {
-                    "required": "You must agree to the {platform_name} {link_label}".format(  # noqa: UP032
-                        platform_name=settings.PLATFORM_NAME,
-                        link_label=link_label
-                    )
-                }
-            }
-        )
-
     @override_settings(MKTG_URLS={
         "ROOT": "https://www.test.com/",
         "HONOR": "honor",
         "TOS": "tos",
     })
-    @mock.patch.dict(settings.FEATURES, {"ENABLE_MKTG_SITE": True})
     def test_registration_separate_terms_of_service_mktg_site_enabled(self):
         # Honor code field should say ONLY honor code,
         # not "terms of service and honor code"
@@ -1245,53 +1211,6 @@ def test_registration_separate_terms_of_service_mktg_site_enabled(self):
             }
         )
 
-    @override_settings(MKTG_URLS_LINK_MAP={"HONOR": "honor", "TOS": "tos"})
-    @mock.patch.dict(settings.FEATURES, {"ENABLE_MKTG_SITE": False})
-    def test_registration_separate_terms_of_service_mktg_site_disabled(self):
-        # Honor code field should say ONLY honor code,
-        # not "terms of service and honor code"
-        link_label = 'Honor Code'
-        self._assert_reg_field(
-            {"honor_code": "required", "terms_of_service": "required"},
-            {
-                "label": "I agree to the {platform_name} {link_label}".format(  # noqa: UP032
-                    platform_name=settings.PLATFORM_NAME,
-                    link_label=self.link_template.format(link_label=link_label)
-                ),
-                "name": "honor_code",
-                "defaultValue": False,
-                "type": "checkbox",
-                "required": True,
-                "errorMessages": {
-                    "required": "You must agree to the {platform_name} Honor Code".format(  # noqa: UP032
-                        platform_name=settings.PLATFORM_NAME
-                    )
-                }
-            }
-        )
-
-        link_label = 'Terms of Service'
-        # Terms of service field should also be present
-        link_template = "<a href='/tos' rel='noopener' target='_blank'>{link_label}</a>"
-        self._assert_reg_field(
-            {"honor_code": "required", "terms_of_service": "required"},
-            {
-                "label": "I agree to the {platform_name} {link_label}".format(  # noqa: UP032
-                    platform_name=settings.PLATFORM_NAME,
-                    link_label=link_template.format(link_label=link_label)
-                ),
-                "name": "terms_of_service",
-                "defaultValue": False,
-                "type": "checkbox",
-                "required": True,
-                "errorMessages": {
-                    "required": "You must agree to the {platform_name} Terms of Service".format(  # noqa: UP032
-                        platform_name=settings.PLATFORM_NAME
-                    )
-                }
-            }
-        )
-
     @override_settings(
         REGISTRATION_EXTRA_FIELDS={
             "level_of_education": "optional",

Original file line number	Diff line number	Diff line change
`@@ -208,9 +208,6 @@ add/change the following:`
`208`	`208`
`209`	`209`	`.. code:: python`
`210`	`210`
`211`		`- FEATURES = {`
`212`		`- 'ENABLE_MKTG_SITE': True,`
`213`		`- }`
`214`	`211`	`MKTG_URLS = {`
`215`	`212`	`'ROOT': '<insert_lms_url_here>',`
`216`	`213`	`}`