refactor: migrate MAX_ENROLLMENT_INSTR_BUTTONS off FEATURES-as-dict

Flat setting was already being assigned to via the instructor plugin's
plugin_settings hook (settings.MAX_ENROLLMENT_INSTR_BUTTONS = 200) — only
the readers were still going through settings.FEATURES.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: feanil

common/djangoapps/student/models/course_enrollment.py

@@ -199,7 +199,7 @@ def is_small_course(self, course_id):
 
         'course_id' is the course_id to return enrollments
         """
-        max_enrollments = settings.FEATURES.get("MAX_ENROLLMENT_INSTR_BUTTONS")
+        max_enrollments = settings.MAX_ENROLLMENT_INSTR_BUTTONS
 
         enrollment_number = super().get_queryset().filter(
             course_id=course_id,

lms/djangoapps/instructor/settings/common.py

@@ -30,7 +30,7 @@ def plugin_settings(settings):
     # .. toggle_tickets: https://github.com/openedx/edx-platform/pull/13196
     settings.ENABLE_CCX_ANALYTICS_DASHBOARD_URL = False
 
-    # .. setting_name: FEATURES['MAX_ENROLLMENT_INSTR_BUTTONS']
+    # .. setting_name: settings.MAX_ENROLLMENT_INSTR_BUTTONS
     # .. setting_default: 200
     # .. setting_description: Disable instructor dashboard buttons for downloading course data
     #   when enrollment exceeds this number. The number indicates the maximum allowed enrollments

lms/djangoapps/instructor/tests/test_api_v2.py

@@ -450,8 +450,7 @@ def test_open_responses_tab_with_openassessment_blocks(self, mock_modulestore):
 
         self.assertIn('open_responses', tab_ids)  # noqa: PT009
 
-    @override_settings(ENABLE_SPECIAL_EXAMS=True)
-    @patch.dict('django.conf.settings.FEATURES', {'MAX_ENROLLMENT_INSTR_BUTTONS': 200})
+    @override_settings(ENABLE_SPECIAL_EXAMS=True, MAX_ENROLLMENT_INSTR_BUTTONS=200)
     def test_special_exams_tab_with_proctored_exams_enabled(self):
         """
         Test that special_exams tab appears when course has proctored exams enabled.
@@ -461,8 +460,7 @@ def test_special_exams_tab_with_proctored_exams_enabled(self):
 
         self.assertIn('special_exams', tab_ids)  # noqa: PT009
 
-    @override_settings(ENABLE_SPECIAL_EXAMS=True)
-    @patch.dict('django.conf.settings.FEATURES', {'MAX_ENROLLMENT_INSTR_BUTTONS': 200})
+    @override_settings(ENABLE_SPECIAL_EXAMS=True, MAX_ENROLLMENT_INSTR_BUTTONS=200)
     def test_special_exams_tab_with_timed_exams_enabled(self):
         """
         Test that special_exams tab appears when course has timed exams enabled.
@@ -479,9 +477,9 @@ def test_special_exams_tab_with_timed_exams_enabled(self):
         tab_ids = [tab['tab_id'] for tab in tabs]
         self.assertIn('special_exams', tab_ids)  # noqa: PT009
 
+    @override_settings(MAX_ENROLLMENT_INSTR_BUTTONS=200)
     @patch('lms.djangoapps.instructor.views.serializers_v2.CertificateGenerationConfiguration.current')
-    @patch('django.conf.settings.FEATURES', {'ENABLE_CERTIFICATES_INSTRUCTOR_MANAGE': True,
-                                             'MAX_ENROLLMENT_INSTR_BUTTONS': 200})
+    @patch.dict('django.conf.settings.FEATURES', {'ENABLE_CERTIFICATES_INSTRUCTOR_MANAGE': True})
     def test_certificates_tab_for_instructor_when_enabled(self, mock_cert_config):
         """
         Test that certificates tab appears for instructors when certificate management is enabled.

lms/djangoapps/instructor/views/gradebook_api.py

@@ -106,7 +106,7 @@ def get_grade_book_page(request, course, course_key):
 def spoc_gradebook(request, course_id):
     """
     Show the gradebook for this course:
-    - Only shown for courses with enrollment < settings.FEATURES.get("MAX_ENROLLMENT_INSTR_BUTTONS")
+    - Only shown for courses with enrollment < settings.MAX_ENROLLMENT_INSTR_BUTTONS
     - Only displayed to course staff
     """
     course_key = CourseKey.from_string(course_id)