Skip to content

Commit d70b4ab

Browse files
feanilclaude
andcommitted
fix: remove E003 system check for MKTG_URLS ROOT key
The E003 check required MKTG_URLS['ROOT'] to be defined, but this key is optional. The index() view in branding/views.py already handles the case where ROOT is absent: root_url = marketing_urls.get("ROOT") if root_url and root_url != getattr(settings, "LMS_ROOT_URL", None): return redirect(root_url) Previously, E003 was only triggered when ENABLE_MKTG_SITE=True (the check was guarded by that flag). After removing ENABLE_MKTG_SITE in #38720, the check runs unconditionally and fires in any environment where MKTG_URLS has no ROOT key (including test and CMS environments). Since ROOT is genuinely optional, the check is incorrect and should not be enforced. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent fbe223e commit d70b4ab

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

  • openedx/core/djangoapps/common_initialization

openedx/core/djangoapps/common_initialization/checks.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,4 @@ def validate_marketing_site_setting(app_configs, **kwargs): # pylint: disable=u
4040
id='common.djangoapps.common_initialization.E002',
4141
)
4242
)
43-
elif not settings.MKTG_URLS.get('ROOT'):
44-
errors.append(
45-
Error(
46-
'There is no ROOT defined in MKTG_URLS.',
47-
id='common.djangoapps.common_initialization.E003',
48-
)
49-
)
5043
return errors

0 commit comments

Comments
 (0)