feat: remove ENABLE_MKTG_SITE from student email view

Email change confirmation contact link now always comes from
marketing_link('CONTACT') via MKTG_URLS. Remove the fallback that
constructed a local URL when the flag was False.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: feanil

common/djangoapps/student/tests/test_email.py

@@ -530,15 +530,7 @@ def assertChangeEmailSent(self, test_body_type):
         # Must have two items in outbox: one for old email, another for new email
         assert len(mail.outbox) == 2
 
-        use_https = self.request.is_secure()
-        if settings.FEATURES['ENABLE_MKTG_SITE']:
-            contact_link = marketing_link('CONTACT')
-        else:
-            contact_link = '{protocol}://{site}{link}'.format(
-                protocol='https' if use_https else 'http',
-                site=settings.SITE_NAME,
-                link=reverse('contact'),
-            )
+        contact_link = marketing_link('CONTACT')
 
         # Verifying contents
         for msg in mail.outbox:
@@ -589,17 +581,10 @@ def test_new_email_fails(self, ace_mail):
     @skip_unless_lms
     @override_settings(MKTG_URLS={'ROOT': 'https://dummy-root', 'CONTACT': '/help/contact-us'})
     @patch('common.djangoapps.student.signals.signals.USER_EMAIL_CHANGED.send')
-    @ddt.data(
-        ('plain_text', False),
-        ('plain_text', True),
-        ('html', False),
-        ('html', True)
-    )
-    @ddt.unpack
-    def test_successful_email_change(self, test_body_type, test_marketing_enabled, mock_email_change_signal):
-        with patch.dict(settings.FEATURES, {'ENABLE_MKTG_SITE': test_marketing_enabled}):
-            self.assertChangeEmailSent(test_body_type)
-            assert mock_email_change_signal.called
+    @ddt.data('plain_text', 'html')
+    def test_successful_email_change(self, test_body_type, mock_email_change_signal):
+        self.assertChangeEmailSent(test_body_type)
+        assert mock_email_change_signal.called
 
         meta = json.loads(UserProfile.objects.get(user=self.user).meta)
         assert 'old_emails' in meta

common/djangoapps/student/tests/test_views.py

@@ -194,7 +194,6 @@ class StudentDashboardTests(SharedModuleStoreTestCase, MilestonesTestCaseMixin,
     MOCK_SETTINGS = {
         'FEATURES': {
             'DISABLE_START_DATES': False,
-            'ENABLE_MKTG_SITE': True,
             'DISABLE_SET_JWT_COOKIES_FOR_TESTS': True,
         },
         'SOCIAL_SHARING_SETTINGS': {

common/djangoapps/student/views/management.py

@@ -924,15 +924,7 @@ def confirm_email_change(request, key):
             transaction.set_rollback(True)
             return response
 
-        use_https = request.is_secure()
-        if settings.FEATURES['ENABLE_MKTG_SITE']:
-            contact_link = marketing_link('CONTACT')
-        else:
-            contact_link = '{protocol}://{site}{link}'.format(
-                protocol='https' if use_https else 'http',
-                site=configuration_helpers.get_value('SITE_NAME', settings.SITE_NAME),
-                link=reverse('contact'),
-            )
+        contact_link = marketing_link('CONTACT')
 
         site = Site.objects.get_current()
         message_context = get_base_template_context(site)