Skip to content

Commit f34e8bf

Browse files
chore: fix lint issues
1 parent e5bbb69 commit f34e8bf

2 files changed

Lines changed: 19 additions & 7 deletions

File tree

openedx/core/djangoapps/content_libraries/tasks.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
BlockUsageLocator,
4646
LibraryContainerLocator,
4747
LibraryLocatorV2,
48+
LibraryUsageLocatorV2,
4849
)
4950
from openedx_content import api as content_api
5051
from openedx_content.api import create_zip_file as create_lib_zip_file
@@ -228,8 +229,12 @@ def check_container_content_changes(
228229
return
229230
else:
230231
# TODO: there is no "get entity list for container version" API in openedx_content
231-
old_child_ids = old_version.entity_list.entitylistrow_set.values_list("entity_id", flat=True) if old_version else []
232-
new_child_ids = new_version.entity_list.entitylistrow_set.values_list("entity_id", flat=True) if new_version else []
232+
old_child_ids = (
233+
old_version.entity_list.entitylistrow_set.values_list("entity_id", flat=True) if old_version else []
234+
)
235+
new_child_ids = (
236+
new_version.entity_list.entitylistrow_set.values_list("entity_id", flat=True) if new_version else []
237+
)
233238
# We only need to notify any added or removed children that their parent container(s) changed:
234239
changed_child_ids = list(set(old_child_ids) ^ set(new_child_ids))
235240

@@ -241,6 +246,7 @@ def check_container_content_changes(
241246
.select_related("component", "container")
242247
)
243248
for entity in entities:
249+
child_key: LibraryUsageLocatorV2 | LibraryContainerLocator
244250
if hasattr(entity, "component"):
245251
child_key = api.library_component_usage_key(library.library_key, entity.component)
246252
elif hasattr(entity, "container"):

openedx/core/djangoapps/content_libraries/tests/test_api.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -351,11 +351,15 @@ def test_set_library_component_collections(self) -> None:
351351
assert all(event["signal"] == LIBRARY_COLLECTION_UPDATED for event in collection_update_events)
352352
assert {event["library_collection"] for event in collection_update_events} == {
353353
LibraryCollectionData(
354-
collection_key=api.library_collection_locator(self.lib2.library_key, collection_key=self.col2.collection_code)
354+
collection_key=api.library_collection_locator(
355+
self.lib2.library_key, collection_key=self.col2.collection_code
356+
)
355357
),
356358
LibraryCollectionData(
357-
collection_key=api.library_collection_locator(self.lib2.library_key, collection_key=self.col3.collection_code)
358-
)
359+
collection_key=api.library_collection_locator(
360+
self.lib2.library_key, collection_key=self.col3.collection_code
361+
)
362+
),
359363
}
360364

361365
def test_delete_library_block(self) -> None:
@@ -380,7 +384,9 @@ def test_delete_library_block(self) -> None:
380384
"signal": LIBRARY_COLLECTION_UPDATED,
381385
"sender": None,
382386
"library_collection": LibraryCollectionData(
383-
collection_key=api.library_collection_locator(self.lib1.library_key, collection_key=self.col1.collection_code),
387+
collection_key=api.library_collection_locator(
388+
self.lib1.library_key, collection_key=self.col1.collection_code
389+
),
384390
),
385391
},
386392
)
@@ -430,7 +436,7 @@ def test_delete_library_container(self) -> None:
430436
"library_container": LibraryContainerData(
431437
container_key=self.subsection1.container_key,
432438
background=False,
433-
)
439+
),
434440
},
435441
)
436442

0 commit comments

Comments
 (0)