refactor: drop unreachable marketing-site branches from enrollment emails

With ENABLE_MKTG_SITE removed, get_email_params() now always sets
course_about_url via get_link_for_about_page(), which never returns None
(it falls back to the LMS course about URL). The instructor "allowed
enroll" and "add beta tester" ACE email templates branched on
`course_about_url is not None`, keeping an else-branch for the old
marketing-site-enabled case where course_about_url was None.

Those conditionals are now always true and their else-branches are dead:
- allowedenroll: "You can then enroll in {{ course_name }}."
- addbetatester: "Visit {{ site_name }} to enroll in this course and
  begin the beta test."

Collapse the always-true `course_about_url is not None` guards to the
unconditional branch and delete the unreachable text (both .txt and .html
variants). No behavior change for any reachable input.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: feanil

lms/templates/instructor/edx_ace/addbetatester/email/body.html

@@ -31,7 +31,7 @@ <h1>
                 </p>
 
                 {% include "ace_common/edx_ace/common/return_to_course_cta.html" with course_cta_text=display_name|default:course.display_name_with_default course_cta_url=course_url %}
-            {% elif course_about_url is not None %}
+            {% else %}
                 <p style="color: rgba(0,0,0,.75);">
                     {% filter force_escape %}
                     {% blocktrans %}To enroll in this course and begin the beta test:{% endblocktrans %}
@@ -43,19 +43,6 @@ <h1>
                 {% endfilter %}
 
                 {% include "ace_common/edx_ace/common/return_to_course_cta.html" with course_cta_text=course_cta_text course_cta_url=course_about_url %}
-            {% else %}
-                <p style="color: rgba(0,0,0,.75);">
-                    {% filter force_escape %}
-                    {% blocktrans %}To enroll in this course and begin the beta test:{% endblocktrans %}
-                    {% endfilter %}
-                    <br />
-                </p>
-                {% filter force_escape %}
-                {% blocktrans asvar course_cta_text %}Visit {{ site_name }}
-                {% endblocktrans %}
-                {%endfilter%}
-
-                {% include "ace_common/edx_ace/common/return_to_course_cta.html" with course_cta_text=course_cta_text course_cta_url=course_url %}
             {% endif %}
 
             <p style="color: rgba(0,0,0,.75);">

lms/templates/instructor/edx_ace/addbetatester/email/body.txt

@@ -3,10 +3,8 @@
 {% blocktrans %}You have been invited to be a beta tester for {{ course_name }} at {{ site_name }} by a member of the course staff.{% endblocktrans %}
 {% if auto_enroll %}
 {% blocktrans %}To start accessing course materials, please visit {{ course_url }}{% endblocktrans %}
-{% elif course_about_url is not None %}
-{% blocktrans %}Visit {{ course_about_url }} to enroll in this course and begin the beta test.{% endblocktrans %}
 {% else %}
-{% blocktrans %}Visit {{ site_name }} to enroll in this course and begin the beta test.{% endblocktrans %}
+{% blocktrans %}Visit {{ course_about_url }} to enroll in this course and begin the beta test.{% endblocktrans %}
 {% endif %}
 ----
 {% blocktrans %}This email was automatically sent from {{ site_name }} to {{ email_address }}{% endblocktrans %}{% endautoescape %}

lms/templates/instructor/edx_ace/allowedenroll/email/body.html

@@ -31,7 +31,7 @@ <h1>
                 </p>
 
                 {% include "ace_common/edx_ace/common/return_to_course_cta.html" with course_cta_text=course_name course_cta_url=course_url %}
-            {% elif course_about_url is not None %}
+            {% else %}
                 <p style="color: rgba(0,0,0,.75);">
                     {% filter force_escape %}
                     {% blocktrans %}To access this course visit it and register:{% endblocktrans %}
@@ -58,16 +58,11 @@ <h1>
                     {# xss-lint: disable=django-blocktrans-missing-escape-filter #}
                     {% blocktrans %}Once you have registered and activated your account, you will see {{ course_name }} listed on your dashboard.{% endblocktrans %}
                     {% endautoescape %}
-                {% elif course_about_url is not None %}
+                {% else %}
                     {% filter force_escape %}
                     {% blocktrans %}Once you have registered and activated your account, you will be able to access this course:{% endblocktrans %}
                     {% endfilter %}
                     {% include "ace_common/edx_ace/common/return_to_course_cta.html" with course_cta_text=course_name course_cta_url=course_about_url %}
-                {% else %}
-                    {% autoescape off %}
-                    {# xss-lint: disable=django-blocktrans-missing-escape-filter #}
-                    {% blocktrans %}You can then enroll in {{ course_name }}.{% endblocktrans %}
-                    {% endautoescape %}
                 {% endif %}
                 <br />
             </p>

lms/templates/instructor/edx_ace/allowedenroll/email/body.txt

@@ -2,13 +2,12 @@
 
 {% blocktrans %}You have been invited to join {{ course_name }} at {{ site_name }} by a member of the course staff.{% endblocktrans %}
 {% if is_shib_course %}{% if auto_enroll %}{% blocktrans %}To access this course visit {{ course_url }} and login.{% endblocktrans %}
-{% elif course_about_url is not None %}
+{% else %}
 {% blocktrans %}To access this course visit {{ course_about_url }} and register for this course.{% endblocktrans %}
 {% endif %}
 {% else %}{% blocktrans %}To finish your registration, please visit {{ registration_url }} and fill out the registration form making sure to use {{ email_address }} in the Email field.{% endblocktrans %}
 {% if auto_enroll %}{% blocktrans %}Once you have registered and activated your account, you will see {{ course_name }} listed on your dashboard.{% endblocktrans %}
-{% elif course_about_url is not None %}{% blocktrans %}Once you have registered and activated your account, visit {{ course_about_url }} to join this course.{% endblocktrans %}
-{% else %}{% blocktrans %}You can then enroll in {{ course_name }}.{% endblocktrans %}
+{% else %}{% blocktrans %}Once you have registered and activated your account, visit {{ course_about_url }} to join this course.{% endblocktrans %}
 {% endif %}
 {% endif %}----
 {% blocktrans %}This email was automatically sent from {{ site_name }} to {{ email_address }}{% endblocktrans %}{% endautoescape %}