test: pin HELP_TOKENS_VERSION in instructor-dashboard SUPPORT_URL tests#38489
Closed
brian-smith-tcril wants to merge 1 commit intoopenedx:masterfrom
Closed
test: pin HELP_TOKENS_VERSION in instructor-dashboard SUPPORT_URL tests#38489brian-smith-tcril wants to merge 1 commit intoopenedx:masterfrom
HELP_TOKENS_VERSION in instructor-dashboard SUPPORT_URL tests#38489brian-smith-tcril wants to merge 1 commit intoopenedx:masterfrom
Conversation
The asserted help-tokens URL includes the doc version, which varies
between master ("latest") and release branches ("open-release-<name>.master"),
causing the tests to fail on release branches. Pin HELP_TOKENS_VERSION
to "latest" so the tests are deterministic regardless of which branch
they run on.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
brian-smith-tcril
force-pushed
the
fix-instructor-help-token-test-version
branch
from
1b7c536 to
361025e
Compare
brian-smith-tcril
changed the title
HELP_TOKENS_VERSION in instructor-dashboard SUPPORT_URL tests
Contributor
Author
|
#38497 landed before this with a similar fix. Closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The instructor-dashboard
SUPPORT_URLtests added in #38446 assert the full help-tokens URL, which includes the doc version.HELP_TOKENS_VERSIONderives fromdoc_version()openedx-platform/openedx/envs/common.py
Line 2529 in bb67094
which returns
"latest"on master but"open-release-<name>.master"on release branches — so the tests fail on release branches (e.g., #38487 againstverawood.master).This pins
HELP_TOKENS_VERSIONto"latest"in the affected tests so the URL is deterministic regardless of which branch the tests run on. The rest of the help-tokens integration (singleton, INI file,HELP_TOKENS_BOOKSlookup) is still exercised end-to-end.Test plan
lms/djangoapps/mfe_config_api/tests/test_views.py)doc_version()returns a non-latestvalue🤖 Generated with Claude Code