chore: remove web_fragments dependency, bump requirements#38741
Conversation
|
Thanks for the pull request, @Kelketek! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
b386d5f to
8da894c
Compare
8da894c to
d234ffc
Compare
1b1f3df to
5012844
Compare
|
@feanil I've made this PR to remove the dependency and re-run upgrades, but it looks like upgrading is throwing in at least one change which is breaking things. How would you prefer I handle this? Should I, instead of running upgrades, just remove the web-fragments dependency, and run |
5012844 to
6e11653
Compare
6e11653 to
7515964
Compare
|
@feanil Upgrading today went cleanly, and this is ready for you, now. Sandbox seems to be fine. |
|
@feanil Do you have an idea when you'll be able to take a look at this? Also the code coverage check failed but it seems unrelated to anything done here (no actual code is changed, just requirements files.) |
|
Looking now! :-) |
|
Yay! Thanks, @feanil ! Can you archive web_fragments? Also, what repo should I look at removing next? :) |
|
@Kelketek can you make an axim-engieering request for the archival. We'll want to track that over there and the on-call person can take care of it. |
Description
This merge request removes
web_fragmentsas a direct dependency and upgrades XBlock. It also upgrades packages generally since the dependencies were recalculated.Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions