refactor: slash-and-burn Poll BuiltIn XBlock#38744
Conversation
|
Thanks for the pull request, @irfanuddinahmad! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
f3724d8 to
83ca0c7
Compare
dd15236 to
155ae51
Compare
Removes the built-in Poll XBlock implementation and all associated assets now that the extracted `xblocks_contrib.poll.PollBlock` is the default (USE_EXTRACTED_POLL_QUESTION_BLOCK has been True since extraction). - Remove USE_EXTRACTED_POLL_QUESTION_BLOCK toggle from common.py - Remove poll_question entrypoint from pyproject.toml - Delete xmodule/poll_block.py (built-in class + shim) - Delete xmodule/js/src/poll/ (JS assets) - Delete lms/templates/poll.html - Delete xmodule/static/css-builtin-blocks/PollBlockDisplay.css - Remove PollBlockDisplay/PollBlockEditor webpack entries - Delete xmodule/tests/test_poll.py (covered by xblocks-contrib) Closes openedx/public-engineering#533 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
155ae51 to
ec54976
Compare
|
Found two real blockers to merging this while testing
This PR shouldn't merge until both are resolved in xblocks-core. Updated the test plan checkboxes above with a note on what the LMS/CMS checks actually cover (rendering, via an OLX-import workaround, since the normal editor is broken) and why CMS V2 Library stays unchecked — it's not a matter of testing harder, that flow is broken for any Poll created directly in a library. |
Summary
Removes the built-in Poll XBlock and all associated assets. The extracted
xblocks_contrib.poll.PollBlockhas been the default sinceUSE_EXTRACTED_POLL_QUESTION_BLOCKwas set toTrue, so the built-in implementation is now dead code.Step 1 of 8 in the Slash-n-Burn Built-In XBlocks epic.
Closes openedx/public-engineering#533
Changes
USE_EXTRACTED_POLL_QUESTION_BLOCKtoggle fromopenedx/envs/common.pypoll_questionentrypoint frompyproject.toml(the xblocks-contrib entrypoint remains active)xmodule/poll_block.py(built-in class + shim)xmodule/js/src/poll/(JS assets)lms/templates/poll.htmlxmodule/static/css-builtin-blocks/PollBlockDisplay.cssPollBlockDisplay/PollBlockEditorwebpack entries fromwebpack.builtinblocks.config.jsandwebpack.common.config.jsxmodule/tests/test_poll.py(covered by xblocks-contrib tests)Epic Step 1: Post-extraction commit review
Reviewed commits to
xmodule/poll_block.pyafterUSE_EXTRACTED_POLL_QUESTION_BLOCKwas set toTrue(2025-12-16 ·24cb3cf9f5). All 3 post-toggle commits were cosmetic: deprecation markers (#38174), import sorting, and lint-amnesty removal. No functional bug fixes or features to port.Test plan
Automated checks (CI):
xmoduleunit tests:pytest xmodule/tests/npm run buildScreenshots on sandbox
CMS

LMS
