feat: bridge FEATURES proxy reads to @override_settings overrides#38818
Merged
Conversation
This was referenced Jun 26, 2026
kdmccormick
approved these changes
Jul 8, 2026
kdmccormick
left a comment
kdmccormick
left a comment
Member
There was a problem hiding this comment.
One suggestion, non-blocking
| """Store the namespace (as a dict)""" | ||
| self.ns = namespace or {} | ||
|
|
||
| _MISSING = object() |
Member
There was a problem hiding this comment.
Suggested change
| _MISSING = object() | |
| _NOT_OVERRIDDEN = object() |
I think this might make the system more self-explanatory. On my initial review I thought _MISSING was a sentinel for something that's missing from settings entirely.
wgu-taylor-payne
approved these changes
Jul 8, 2026
Lets @override_settings(KEY=val) be seen through both settings.KEY
and settings.FEATURES['KEY']/.get('KEY'), so tests can migrate to
the flat setting without first updating every production reader
that still does settings.FEATURES['KEY'].
We walk only the UserSettingsHolder chain that @override_settings
pushes onto django.conf.settings._wrapped, NOT the bottom Settings
layer. Django's bottom Settings is a *snapshot* of the settings
module's globals taken at init time, so it doesn't reflect runtime
mutations of the module's globals — which is exactly what legacy
patch.dict(settings.FEATURES, ...) does via proxy.ns. Reading the
snapshot would mask those mutations and break legacy tests; walking
only the explicit override layers lets both paths coexist during
the migration.
ns kept as-is. A stateless redesign (drop ns, route everything
through django.conf.settings, set FEATURES = FeaturesProxy() in
each env file) was considered but rejected for this step because
FEATURES.copy() and __iter__ are widely used to snapshot the full
set of feature flags; without ns there is no clean source of truth
for "which keys are features". Once all callers have moved off the
dict pattern the proxy can be deleted outright (every
settings.FEATURES['X'] becomes settings.X), making the stateless
refactor unnecessary.
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
feanil
force-pushed
the
feanil/features-dict-bridge
branch
from
3a686d6 to
1299ef1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR in a 3-PR stack that migrates callers off of
settings.FEATURES['X']access. Follow-on to #38771.This PR adds a single bridge to
FeaturesProxyso thatsettings.FEATURES.get('X')walks theUserSettingsHolderchain — i.e. an@override_settings(X=...)decorator on the new flat setting is visible to legacy callers that still read the FEATURES dict. This lets us migrate call sites incrementally (#38772) without breaking unmigrated tests.Stack: