temp: report FEATURES-as-dict warning at the real caller#38819
Closed
feanil wants to merge 0 commit into
Closed
Conversation
This was referenced Jun 26, 2026
feanil
force-pushed
the
feanil/features-dict-migration
branch
from
346382f to
520006a
Compare
feanil
force-pushed
the
feanil/features-dict-migration
branch
from
520006a to
20636c5
Compare
feanil
force-pushed
the
feanil/features-dict-temp
branch
from
55b8500 to
a1dd86b
Compare
feanil
force-pushed
the
feanil/features-dict-migration
branch
2 times, most recently
from
529d37b to
d975a1e
Compare
feanil
force-pushed
the
feanil/features-dict-temp
branch
from
a1dd86b to
d975a1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third PR in the FEATURES-as-dict migration stack. Stacked on #38772.
Single
temp:commit that fixesFeaturesProxy'sstacklevelso theAccessing FEATURES as a dict is deprecatedDeprecationWarning points at the real caller instead of always reporting line 89 of the proxy itself. Used to drive the migration: each green-CI run surfaces the list of flags still left to migrate.Not for merge — this PR exists so we can iterate on the surfaced list while the upstream bridge / migration PRs land. Will be closed once every flag is migrated and
FeaturesProxyis deleted.Stack: