feat: remove border radius & extra content by filippovskii09 · Pull Request #4083 · openedx/paragon

filippovskii09 · 2026-01-12T09:31:54Z

Description

In this PR was added style fixes for Search Submit Button

Issues

#2674
#4023

Before:

After:

openedx-webhooks · 2026-01-12T09:31:59Z

Thanks for the pull request, @filippovskii09!

This repository is currently maintained by @openedx/committers-paragon.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

netlify · 2026-01-12T09:32:00Z

✅ Deploy Preview for paragon-openedx-v23 ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`5a8f031`
🔍 Latest deploy log	https://app.netlify.com/projects/paragon-openedx-v23/deploys/69bc45169923c600087d7ba8
😎 Deploy Preview	https://deploy-preview-4083--paragon-openedx-v23.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

codecov · 2026-01-12T09:45:36Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.39%. Comparing base (dfc69e2) to head (5a8f031).
⚠️ Report is 46 commits behind head on release-23.x.

Additional details and impacted files

@@              Coverage Diff              @@
##           release-23.x    #4083   +/-   ##
=============================================
  Coverage         94.39%   94.39%           
=============================================
  Files               242      243    +1     
  Lines              4296     4299    +3     
  Branches           1020      982   -38     
=============================================
+ Hits               4055     4058    +3     
  Misses              237      237           
  Partials              4        4

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

peterkulko

I checked, it seems to look much better now. Thanks for this fix!

brian-smith-tcril · 2026-01-29T15:05:29Z

 export const SEARCH_FIELD_SCREEN_READER_TEXT_SUBMIT_BUTTON = 'submit search';
 export const SEARCH_FIELD_SCREEN_READER_TEXT_CLEAR_BUTTON = 'clear search';
-export const SEARCH_FIELD_BUTTON_TEXT = 'search';
+export const SEARCH_FIELD_BUTTON_TEXT = 'Search';


We should probably just remove this completely. We already have a default for buttonText in SearchField.SubmitButton

paragon/src/SearchField/SearchFieldSubmitButton.jsx

Lines 70 to 74 in d2dc235

SearchFieldSubmitButton.defaultProps = {

variant: 'light',

submitButtonLocation: 'internal',

buttonText: 'Search',

};

So it'd be nice to not have this defined in 2 places.

The SEARCH_FIELD_BUTTON_TEXT variable has been removed

I think it would be good to have translations for the "Search" string.
Currently, we have an ongoing forum discussion about incorrect translations, which also concerns the SearchField component button text.

@filippovskii09 could you please wrap this text into translations?

@PKulkoRaccoonGang translation was added!

…o filippovskii/fix/styles-for-search-button

gabrieldamours · 2026-06-29T18:06:01Z

Hi @brian-smith-tcril! Same here: would you mind giving this PR a quick check? We're hoping to unblock it as part of the ongoing PR spring cleaning hackathon. Thanks!

brian-smith-tcril · 2026-06-30T15:05:42Z

Closing the loop on the Search vs search change before diving into a full review:

It appears the button used to display Search, but when #1154 landed (specifically 56ec789 with a commit message of "feat: export default strings as constants for use in consumer tests") the string added for export was set to search instead.

This makes be believe that Search is the intended text, and the change to search was a regression, so the change back to Search in this PR is appropriate.

brian-smith-tcril

Overall this looks great! I left one tiny naming comment. Once that is resolved this should be good to land!

brian-smith-tcril · 2026-06-30T15:11:54Z

    screenReaderText, icons, refs, value, disabled,
  } = useContext(SearchFieldContext);
+  const intl = useIntl();
+  const defaultButtonText = buttonText ?? intl.formatMessage(messages.searchButtonText);


The default naming feels strange here. I think of intl.formatMessage(messages.searchButtonText) as the "default" so having the prop-supplied buttonText go into something named defaultButtonText feels off. I'd recommend resolvedButtonText as an alternative, but I'm open to other ideas.

feat: remove border radius & extra contetn & add capitalize

f4338dd

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 12, 2026

openedx-webhooks added this to Contributions Jan 12, 2026

github-project-automation Bot moved this to Needs Triage in Contributions Jan 12, 2026

filippovskii09 marked this pull request as ready for review January 12, 2026 09:52

filippovskii09 mentioned this pull request Jan 12, 2026

fix: resolve styles issues for search submit button #4048

Closed

10 tasks

ihor-romaniuk approved these changes Jan 13, 2026

View reviewed changes

Comment thread src/SearchField/index.scss Outdated

fix: remove extra css property

bab087f

peterkulko assigned filippovskii09 Jan 14, 2026

filippovskii09 changed the title ~~feat: remove border radius & extra contetn & add capitalize~~ feat: remove border radius & extra content Jan 15, 2026

peterkulko requested changes Jan 15, 2026

View reviewed changes

Comment thread src/SearchField/index.scss Outdated

fix: change hard value to default value for bd radius

01f082d

filippovskii09 requested a review from peterkulko January 15, 2026 14:31

mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Jan 16, 2026

peterkulko approved these changes Jan 28, 2026

View reviewed changes

peterkulko requested a review from brian-smith-tcril January 29, 2026 07:31

brian-smith-tcril reviewed Jan 29, 2026

View reviewed changes

filippovskii09 added 2 commits February 5, 2026 16:40

Merge branch 'release-23.x' of https://github.com/openedx/paragon int…

f57c2aa

…o filippovskii/fix/styles-for-search-button

fix: remove search button text constant

24df154

filippovskii09 requested a review from brian-smith-tcril February 6, 2026 12:32

peterkulko mentioned this pull request Mar 11, 2026

Missing translations in SearchField and DataTable components #4115

Open

feat: add translation for search button

5a8f031

filippovskii09 requested a review from peterkulko March 20, 2026 07:30

itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jun 25, 2026

brian-smith-tcril reviewed Jun 30, 2026

View reviewed changes

	SearchFieldSubmitButton.defaultProps = {
	variant: 'light',
	submitButtonLocation: 'internal',
	buttonText: 'Search',
	};

Uh oh!

Conversation

filippovskii09 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues

Uh oh!

openedx-webhooks commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for paragon-openedx-v23 ready!

Uh oh!

codecov Bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

peterkulko left a comment

Choose a reason for hiding this comment

Uh oh!

brian-smith-tcril Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

filippovskii09 Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

peterkulko Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

filippovskii09 Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

gabrieldamours commented Jun 29, 2026

Uh oh!

brian-smith-tcril commented Jun 30, 2026

Uh oh!

brian-smith-tcril left a comment

Choose a reason for hiding this comment

Uh oh!

brian-smith-tcril Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

filippovskii09 commented Jan 12, 2026 •

edited

Loading

openedx-webhooks commented Jan 12, 2026 •

edited

Loading

netlify Bot commented Jan 12, 2026 •

edited

Loading

codecov Bot commented Jan 12, 2026 •

edited

Loading