Skip to content

Commit 964f5d7

Browse files
committed
fix: Don't try to save artifacts if we didn't release.
Update the name of the second step to be more clear and correct the related comment as well.
1 parent ffbdfc7 commit 964f5d7

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

.github/workflows/release.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ jobs:
5656

5757
- name: Upload | Distribution Artifacts
5858
uses: actions/upload-artifact@v4
59+
if: steps.release.outputs.released == 'true'
5960
with:
6061
name: distribution-artifacts
6162
path: backend/dist
@@ -64,10 +65,10 @@ jobs:
6465
outputs:
6566
released: ${{ steps.release.outputs.released || 'false' }}
6667

67-
deploy:
68-
# 1. Separate out the deploy step from the publish step to run each step at
68+
publish:
69+
# 1. Separate out the publish step from the github release step to run each step at
6970
# the least amount of token privilege
70-
# 2. Also, deployments can fail, and its better to have a separate job if you need to retry
71+
# 2. Also, publishing can fail, and its better to have a separate job if you need to retry
7172
# and it won't require reversing the release.
7273
runs-on: ubuntu-latest
7374
needs: release

0 commit comments

Comments
 (0)