feat: add frontend-base sibling alongside legacy FPF plugin#45
Open
arbrandes wants to merge 1 commit into
Open
feat: add frontend-base sibling alongside legacy FPF plugin#45arbrandes wants to merge 1 commit into
arbrandes wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage 93.04% 93.04%
=======================================
Files 16 16
Lines 503 503
Branches 18 18
=======================================
Hits 468 468
Misses 24 24
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Introduce frontend-app-sample/ next to the existing frontend-plugin-sample/. The new directory is a frontend-base app, written in TypeScript, that contributes a widgetReplace operation against the learner-dashboard's CourseList slot on the bundled tutor-mfe site. The legacy directory stays put, unchanged, and keeps targeting the per-MFE env.config.jsx flow. Have tutor-contrib-sample register both. The operator picks which one fires by enabling (or not) the frontend-base learner-dashboard app in tutor-mfe. Co-Authored-By: Claude <noreply@anthropic.com>
4467d7e to
7287637
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
frontend-app-sample/alongside the existingfrontend-plugin-sample/. The former does the same thing as the latter, but for the frontend-base version of Learner Dashboard.tutor-contrib-sampleregisters both. The operator picks which one actually fires by enabling (or not) the frontend-baselearner-dashboardapp in tutor-mfe'sFRONTEND_APPSfilter.Note that one of the README's links out to openedx/docs.openedx.org#1459, which hasn't merged yet.
How to test
Install
tutor-contrib-samplefrom this repo and enable it as usual. Then enable the frontend-base version of Learner Dashboard by adding a tiny standalone Tutor plugin that flips the toggle:Enable it:
tutor plugins enable fb-learner-dashboardNow bind-mount
frontend-app-sample/. This is required because it's not yet published to NPM:Launch:
The frontend-base site should pick up the slot operation from
@openedx/frontend-app-sample. The Archive/Unarchive buttons should now render via the new path on the frontend-base learner dashboard athttp://apps.local.openedx.io:8080/learner-dashboard/(note the 8080 port that tells it apart from the legacy version at port 1996).Behind the scenes, tutor-mfe auto-detects the
frontend-app-prefix and mounts it as a workspace package underpackages/frontend-app-samplein themfe-devcontainer, so edits hot-reload without rebuilds. You can check with:LLM usage notice
Built with assistance from Claude.