Skip to content

fix: adds the port to superset's metadata sqlalchemy uri#1268

Merged
bmtcril merged 1 commit into
openedx:aspects2.5updatesfrom
open-craft:tecoholic/BB-10779-patch-metadata-sqlalchemy-url
Jun 24, 2026
Merged

fix: adds the port to superset's metadata sqlalchemy uri#1268
bmtcril merged 1 commit into
openedx:aspects2.5updatesfrom
open-craft:tecoholic/BB-10779-patch-metadata-sqlalchemy-url

Conversation

@tecoholic

@tecoholic tecoholic commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Backport of #1267 for 2.5 (Teak) compatible version. More details are available on #1267's description.

NOTE: The target branch is chosen based on the branch name. We are trying to backport this to 2.5.1 (which we are using for our Teak instance).

When MySQL is being served in non-default port, the SUPERSET_METADATA_SQLALCHEMY_URI becomes invalid as there is not explicit port. This commit adds the port to the URI.

Internal-ref: https://tasks.opencraft.com/browse/BB-10779

When MySQL is being served in non-default port, the
SUPERSET_METADATA_SQLALCHEMY_URI becomes invalid as there is not
explicit port. This commit adds the port to the URI.

Internal-ref: https://tasks.opencraft.com/browse/BB-10779
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 18, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @tecoholic!

This repository is currently maintained by @openedx/tutor-contrib-aspects-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@tecoholic

Copy link
Copy Markdown
Contributor Author

@farhaanbukhsh Hi, can you review this as CC?

@farhaanbukhsh

Copy link
Copy Markdown
Member

@tecoholic I can :)

@tecoholic tecoholic requested a review from farhaanbukhsh June 18, 2026 05:29
@tecoholic tecoholic self-assigned this Jun 18, 2026
@tecoholic

tecoholic commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

@farhaanbukhsh If it's helpful - the change to the main is merged in #1267 :)

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jun 23, 2026
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Jun 23, 2026
@mphilbrick211 mphilbrick211 moved this from Ready for Review to Needs Triage in Contributions Jun 23, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jun 23, 2026

@farhaanbukhsh farhaanbukhsh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

✅ I tested this:

  • Generated the yml files which have these values
    ✅ I read through the code
    ❌ I checked for accessibility issues
    ❌ Includes documentation

@farhaanbukhsh

farhaanbukhsh commented Jun 24, 2026

Copy link
Copy Markdown
Member

@bmtcril I have reviewed this. Please have a look and see if this makes sense to be merged :) Thanks a lot in advance.

@bmtcril bmtcril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok, but @saraburns1 we should probably include it in the Verawood branch as a backport too

@bmtcril bmtcril merged commit 8841357 into openedx:aspects2.5updates Jun 24, 2026
23 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions Jun 24, 2026
@farhaanbukhsh

Copy link
Copy Markdown
Member

thank you so much @bmtcril !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants