fix: adds the port to superset's metadata sqlalchemy uri#1268
Conversation
When MySQL is being served in non-default port, the SUPERSET_METADATA_SQLALCHEMY_URI becomes invalid as there is not explicit port. This commit adds the port to the URI. Internal-ref: https://tasks.opencraft.com/browse/BB-10779
|
Thanks for the pull request, @tecoholic! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@farhaanbukhsh Hi, can you review this as CC? |
|
@tecoholic I can :) |
|
@farhaanbukhsh If it's helpful - the change to the main is merged in #1267 :) |
farhaanbukhsh
left a comment
There was a problem hiding this comment.
👍
✅ I tested this:
- Generated the yml files which have these values
✅ I read through the code
❌ I checked for accessibility issues
❌ Includes documentation
|
@bmtcril I have reviewed this. Please have a look and see if this makes sense to be merged :) Thanks a lot in advance. |
bmtcril
left a comment
There was a problem hiding this comment.
This is ok, but @saraburns1 we should probably include it in the Verawood branch as a backport too
|
thank you so much @bmtcril ! |
Backport of #1267 for 2.5 (Teak) compatible version. More details are available on #1267's description.
NOTE: The target branch is chosen based on the branch name. We are trying to backport this to 2.5.1 (which we are using for our Teak instance).
When MySQL is being served in non-default port, the SUPERSET_METADATA_SQLALCHEMY_URI becomes invalid as there is not explicit port. This commit adds the port to the URI.
Internal-ref: https://tasks.opencraft.com/browse/BB-10779