Skip to content

Commit fa7dcbe

Browse files
farhanclaude
andcommitted
style: revert tooling config to master parity
Remove extra pylint disable rules, mypy module overrides, and pycodestyle ignores added during CI fix that deviate from master. Revert pylintrc_tweaks, pylintrc, pyproject.toml, and tox.ini to match upstream master configuration exactly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent a4779f4 commit fa7dcbe

5 files changed

Lines changed: 4 additions & 79 deletions

File tree

pylintrc

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ enable =
8181
access-member-before-definition,
8282
anomalous-backslash-in-string,
8383
anomalous-unicode-escape-in-string,
84+
arguments-differ,
8485
assert-on-tuple,
8586
assigning-non-slot,
8687
assignment-from-no-return,
@@ -287,27 +288,6 @@ disable =
287288
logging-fstring-interpolation,
288289
consider-using-with,
289290
bad-option-value,
290-
arguments-differ,
291-
too-many-positional-arguments,
292-
abstract-method,
293-
missing-class-docstring,
294-
missing-module-docstring,
295-
redefined-outer-name,
296-
unused-argument,
297-
attribute-defined-outside-init,
298-
unused-variable,
299-
line-too-long,
300-
super-with-arguments,
301-
use-implicit-booleaness-not-len,
302-
use-implicit-booleaness-not-comparison,
303-
redefined-builtin,
304-
use-a-generator,
305-
protected-access,
306-
import-outside-toplevel,
307-
consider-using-sys-exit,
308-
consider-using-in,
309-
consider-using-generator,
310-
consider-using-enumerate,
311291

312292
[REPORTS]
313293
output-format = text

pylintrc_tweaks

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -7,24 +7,3 @@ load-plugins = edx_lint.pylint,pylint_celery
77
disable+ =
88
consider-using-with,
99
bad-option-value,
10-
arguments-differ,
11-
too-many-positional-arguments,
12-
abstract-method,
13-
missing-class-docstring,
14-
missing-module-docstring,
15-
redefined-outer-name,
16-
unused-argument,
17-
attribute-defined-outside-init,
18-
unused-variable,
19-
line-too-long,
20-
super-with-arguments,
21-
use-implicit-booleaness-not-len,
22-
use-implicit-booleaness-not-comparison,
23-
redefined-builtin,
24-
use-a-generator,
25-
protected-access,
26-
import-outside-toplevel,
27-
consider-using-sys-exit,
28-
consider-using-in,
29-
consider-using-generator,
30-
consider-using-enumerate,

pyproject.toml

Lines changed: 1 addition & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ test = [
5454

5555
quality = [
5656
{include-group = "test"},
57-
"build",
5857
"edx-lint",
5958
"isort",
6059
"mypy",
@@ -126,36 +125,9 @@ skip = ["migrations"]
126125
python_version = "3.12"
127126
ignore_missing_imports = true
128127
check_untyped_defs = false
129-
warn_unused_ignores = false
128+
warn_unused_ignores = true
130129
exclude = ["^docs/", "^build/", "^dist/"]
131130

132131
[[tool.mypy.overrides]]
133132
module = "xapi_db_load.tests.*"
134133
ignore_errors = true
135-
136-
[[tool.mypy.overrides]]
137-
module = [
138-
"xapi_db_load.async_app",
139-
"xapi_db_load.backends.base_async_backend",
140-
"xapi_db_load.backends.chdb",
141-
"xapi_db_load.backends.clickhouse",
142-
"xapi_db_load.backends.csv",
143-
"xapi_db_load.course_configs",
144-
"xapi_db_load.generate_load_async",
145-
"xapi_db_load.ui.config_ui",
146-
"xapi_db_load.ui.log_ui",
147-
"xapi_db_load.ui.main_ui",
148-
"xapi_db_load.xapi.xapi_grade",
149-
"xapi_db_load.xapi.xapi_hint_answer",
150-
"xapi_db_load.xapi.xapi_navigation",
151-
"xapi_db_load.xapi.xapi_problem",
152-
]
153-
ignore_errors = true
154-
155-
[tool.pylint."messages control"]
156-
disable = [
157-
"arguments-differ",
158-
]
159-
160-
[tool.pylint.design]
161-
max-positional-arguments = 6

tox.ini

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,8 @@ ignore=D001
1010
exclude = .git,.tox
1111
max-line-length = 120
1212
max-doc-length = 120
13-
; E501 = Line too long, handled in pylint
14-
; W503 = line break before binary operator (pre-existing style)
15-
; W505 = doc line too long (pre-existing long comments)
16-
ignore = E501,W503,W505
13+
; E501 = Line too long, this is handled in pylint
14+
ignore = E501
1715

1816
[pydocstyle]
1917
; D101 = Missing docstring in public class

uv.lock

Lines changed: 0 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)