Skip to content

Commit 94ac572

Browse files
feanilclaude
authored andcommitted
build: add webpack-merge ^5 to discussion and problem assets
These webpack configs use const { merge } = require('webpack-merge') which is webpack-merge v5 API. However webpack-merge was only present as a transitive dep at v4 (pulled in by karma-webpack ^0.13), causing TypeError: merge is not a function at build time. Adding it as a direct devDependency at ^5 causes npm to install v5 under each workspace's node_modules, matching what the configs require. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 96a7cd1 commit 94ac572

3 files changed

Lines changed: 36 additions & 2 deletions

File tree

package-lock.json

Lines changed: 34 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/xblock_discussion/assets/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
"imports-loader": "^0.8",
1717
"webpack": "^5",
1818
"webpack-cli": "^5",
19+
"webpack-merge": "^5",
1920
"draggabilly": "^3.0.0",
2021
"edx-ui-toolkit": "^1",
2122
"jasmine-core": "2.6.4",

src/xblock_problem/assets/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
},
2121
"devDependencies": {
2222
"copy-webpack-plugin": "^14.0.0",
23+
"webpack-merge": "^5",
2324
"jasmine-core": "2.6.4",
2425
"jasmine-jquery": "git+https://git@github.com/velesin/jasmine-jquery.git#ebad463d592d3fea00c69f26ea18a930e09c7b58",
2526
"karma-coverage": "^2",

0 commit comments

Comments
 (0)